TheME
January 11, 2025, 11:33am
1
Every time a client gets rate limited, the warning message on the diagnosis site states a very high limitation period (of several days converted).
At the same time, FTP.log
shows a period of just 31 seconds
.
Debug token: rYozhVNu
Interesting. This looks like an integer conversion issue.
I tried to rate limit my own client and both loggings are the same (18 seconds).
DL6ER
January 12, 2025, 7:21am
9
I tried to reproduce this locally but failed:
Everything looks fine over here - this makes it a bit harder to debug this. Nonetheless, I tried my best to prevent any possible type conversations by reducing the overall number of variable casts which is probably what is causing this for you.
Could you please try whether the issue is fixed after
sudo pihole checkout ftl fix/turnaround
?
pi-hole:development
← pi-hole:fix/turnaround
opened 07:22AM - 12 Jan 25 UTC
# What does this implement/fix?
Fix a value overflow in the rate-limiting dia… gnosis message reported on Discourse.
---
**Related issue or feature (if applicable):** https://discourse.pi-hole.net/t/client-has-been-rate-limited-for-at-least-3217188-seconds/75091
**Pull request in [docs](https://github.com/pi-hole/docs) with documentation (if applicable):** N/A
---
**By submitting this pull request, I confirm the following:**
1. I have read and understood the [contributors guide](https://docs.pi-hole.net/guides/github/contributing/), as well as this entire template. I understand which branch to base my commits and Pull Requests against.
2. I have commented my proposed changes within the code.
3. I am willing to help maintain this change if there are issues with it later.
4. It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1)
5. I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html))
## Checklist:
- [x] The code change is tested and works locally.
- [x] I based my code and PRs against the repositories `developmental` branch.
- [x] I [signed off](https://docs.pi-hole.net/guides/github/how-to-signoff/) all commits. Pi-hole enforces the [DCO](https://docs.pi-hole.net/guides/github/dco/) for all contributions
- [x] I [signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) all my commits. Pi-hole requires signatures to verify authorship
- [x] I have read the above and my PR is ready for review.
DL6ER
January 15, 2025, 6:16pm
11
The fix has been merged. Please go back using
sudo pihole checkout ftl development