Charts on the dashboard are broken when no queries

TheME · October 24, 2023, 7:16pm

Right after a fresh installation or even if no queries have been made in the last 24 hours, the charts on the dashboard are broken and the browser's development tool console throws out an error.

yubiuser · October 24, 2023, 9:19pm

I can reproduce the issue. The culprit is

If a single query is available, the issue resolved.
Reason is we assume there are queries

github.com

pi-hole/web/blob/82f1965d4d652a4eb026b42b10839a2e1929380f/scripts/pi-hole/js/index.js#L43-L44


      
          // Add data for each dataset that is available
          data.history.forEach(function (item) {

yubiuser · October 24, 2023, 9:34pm

github.com/pi-hole/web

Fix dashboard when no queries are present

pi-hole:development-v6 ← pi-hole:fix/no_queries

opened 09:34PM - 24 Oct 23 UTC

yubiuser

+11 -1

**What does this PR aim to accomplish?:** Fixes the dashboard boxes for "Quer…ies over time" and "Clients over time" if no queries are present. Reported here: https://discourse.pi-hole.net/t/charts-on-the-dashboard-are-broken-when-no-queries/65852/2 **How does this PR accomplish the above?:** Remove the boxes if no queries are present. Re-use already present code from "Clients over time" also for "Queries over time" (and fixes "Clients over time"). ![Screenshot at 2023-10-24 23-30-43](https://github.com/pi-hole/web/assets/26622301/10c19eee-4df1-4bf4-9fd5-562fc1c03e95) --- **By submitting this pull request, I confirm the following:** 1. I have read and understood the [contributors guide](https://docs.pi-hole.net/guides/github/contributing/), as well as this entire template. I understand which branch to base my commits and Pull Requests against. 2. I have commented my proposed changes within the code and I have tested my changes. 3. I am willing to help maintain this change if there are issues with it later. 4. It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1) 5. I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html)) 6. I have checked that another pull request for this purpose does not exist. 7. I have considered, and confirmed that this submission will be valuable to others. 8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer. 9. I give this submission freely, and claim no ownership to its content. --- - [x] I have read the above and my PR is ready for review. *Check this box to confirm*