Please follow the below template, it will help us to help you!
If you are Experiencing issues with a Pi-hole install that has non-standard elements (e.g you are using nginx
instead of lighttpd
, or there is some other aspect of your install that is customised) - please use the Community Help category.
Expected Behaviour:
[I'm trying to add the Rakuten whitelist so that I can get my cash back extension working. However, it seems adding txt links was deprecated at some point. How do I fix this so I can add the whitelist? The whitelist is located at this link .]
Actual Behaviour:
[Using the Rakuten cash back extension is blocked.]
Debug Token:
[https://tricorder.pi-hole.net/k1NVUlfi/ )]
Every entry in this list is invalid and Pi-hole will ignore them.
Pi-hole only accepts entries using the format ||domain^
(only to block domains).
Pi-hole doesn't accept entries starting with @@||
.
development
← new/adb_style_blocking
opened 08:21PM - 15 Feb 23 UTC
# What does this implement/fix?
This PR implements support for AdBlock Plus (… ABP)-style domain lists in Pi-hole. To be precise, it adds support for the following domain matching syntax defined [here](https://adblockplus.org/filter-cheatsheet#blocking2) at the time of opening this PR:

We do *not* implement any other features such as *exception rules* as they are typically beyond what a DNS server can do (path information, for instance, is simply not available).
It should be noted that this new feature is not for free but the rather complex syntax means it comes at some computational costs (= delays in DNS replies if you are on low-end hardware). To mitigate this drawback, ABP-style matching is only enabled when FTL actually detects such domains in the `gravity` table. This shouldn't be the case for the vast majority of users using "normal" HOSTS-style or simple one-domain-per-line adlists as sources for Pi-hole.
**Related issue or feature (if applicable):** N/A
**Pull request in [docs](https://github.com/pi-hole/docs) with documentation (if applicable):** N/A
---
**By submitting this pull request, I confirm the following:**
1. I have read and understood the [contributors guide](https://docs.pi-hole.net/guides/github/contributing/), as well as this entire template. I understand which branch to base my commits and Pull Requests against.
4. I have commented my proposed changes within the code.
6. I am willing to help maintain this change if there are issues with it later.
7. It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1)
8. I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html))
## Checklist:
- [x] The code change is tested and works locally.
- [x] I based my code and PRs against the repositories `developmental` branch.
- [x] I [signed off](https://docs.pi-hole.net/guides/github/how-to-signoff/) all commits. Pi-hole enforces the [DCO](https://docs.pi-hole.net/guides/github/dco/) for all contributions
- [x] I [signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) all my commits. Pi-hole requires signatures to verify authorship
- [x] I have read the above and my PR is ready for review.
You need to manually add whitelist entries (using domains or regex) in web interface Domains page.
system
Closed
May 25, 2024, 3:27am
3
This topic was automatically closed 21 days after the last reply. New replies are no longer allowed.