Proposed feature(s): Bulk blacklist/whitelist input
Similar in interface to the feature for adding multiple ad and malware [subscription] lists, but for the purpose of bulk user input of domains for blacklist and whitelist purposes. Currently, the user must enter each domain individually to either the blacklist or whitelist. Allowing for multiple entries can save the user time if this can be processed efficiently by pi-hole.
Thank you for checking out this feature request. Thank you for your time.
jfb
October 8, 2018, 10:27pm
2
I believe this already exists. Make a text file with a domain on each line. Then select the contents of the file, paste into the whitelist "add a domain" section, and click "add". This should put them separately into the whitelist.
I never knew this existed. Thus the feature request.
Implemented long time ago via *.txt
file , but also possible with v5.0's database
pi-hole:release/v5.0
← pi-hole:new/space-separated-item-injection
opened 07:12PM - 11 Feb 20 UTC
**By submitting this pull request, I confirm the following:**
- [X] I have r… ead and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md), as well as this entire template.
- [X] I have made only one major change in my proposed changes.
- [X] I have commented my proposed changes within the code.
- [X] I have tested my proposed changes, and have included unit tests where possible.
- [X] I am willing to help maintain this change if there are issues with it later.
- [X] I give this submission freely and claim no ownership.
- [X] It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1)
- [X] I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html))
---
**What does this PR aim to accomplish?:**
Allow users to add multiple groups/clients/domains/adlists at once by space-separating them. All added items will receive the same comment (if specified).
**Example 1**
![Screenshot from 2020-02-11 20-05-57](https://user-images.githubusercontent.com/16748619/74269873-84b9c400-4d0a-11ea-86f2-e7d11e576b45.png)
resulting in:
![Screenshot from 2020-02-11 20-06-03](https://user-images.githubusercontent.com/16748619/74269878-85eaf100-4d0a-11ea-8a9f-c603638bab91.png)
**Example 2**
![Screenshot from 2020-02-11 20-06-29](https://user-images.githubusercontent.com/16748619/74269838-753a7b00-4d0a-11ea-9d4e-1fd91bd46540.png)
resulting in:
![Screenshot from 2020-02-11 20-06-41](https://user-images.githubusercontent.com/16748619/74269843-77043e80-4d0a-11ea-89bd-bdea7bcd19ca.png)
Also, we remove the redundant list management from the settings page as this code was only partially migrated to the database backend (it was planed to be replace, anyway) and still uses CLI callbacks in the background. It is not needed any longer. I added a link to the new page so users will not be confused by a sudden absence of the settings tab.
**How does this PR accomplish the above?:**
Implement processing of space-separated items as individual entries.
**What documentation changes (if any) are needed to support this PR?:**
None