Blocklist entries ignored if "#" (comment) after the domain

Pi-hole version is v4.3.5-467-g413fa94 (Latest: v4.4)
AdminLTE version is v4.3.2-464-gade3ef5 (Latest: v4.3.3)
FTL version is vDev-853261b (Latest: v4.3.1)

Problem with Beta 5.0:
If there is a "#" after the domain in a blocklist (a comment) then Pi-hole seems to be ignoring the entire line and does not add the domain.

Here's a list that has a comment (#) after each domain and Pi-hole will not pull any domains into the database.

https://gitlab.com/quidsup/notrack-blocklists/raw/master/notrack-malware.txt

If there is a mix of commented/not commented lines in the blocklist Pi-hole will pull the not commented lines. Here's a list like that.

https://gitlab.com/quidsup/notrack-blocklists/raw/master/notrack-blocklist.txt

I run two Pi-holes, one Beta the other not... Running the same blocklists on each I see that the original Pi-hole shows more domains in the "Domains on Blocklist" counter than the Beta. So, i'm guessing the original Pi-hole pulls the domains that have comments. But, that's a guess...

Thanks

There is already a fix for this in the pipeline:

Hey yubiuser...

Thanks, I missed that...

Best

Fix is merged. Should be in release/v5.0 branch if you pihole -up.

Hey DanSchaper,

Thanks. Done, works well...

Best

1 Like