Audit Log / DNS & FTL Aussetzer nach Update auf 5.1.1

peneu76 · July 17, 2020, 3:05am

Gibt es schon eine Lösung für die Audit log Buttons?

yubiuser · July 17, 2020, 6:22am

Nein.

peneu76 · July 17, 2020, 2:48pm

24 Stunden nach dem "Eingriff" - Pihole läuft einfach superb - smooth and sexy.

Coro · July 20, 2020, 5:49am

Vielleicht ist das einfach untergegangen. @DL6ER hat hier geschrieben, dass er sich das anschauen will: FTL crashes when adding domain to audit · Issue #841 · pi-hole/FTL · GitHub Generell scheint es sehr an FTL hinterher zu sein, in die schiere Menge an Issue Tickets geht etwas bei Web vermutlich unter. Wer soll sich schon um all das kümmern [Ich muss auch mal anfangen javascript zu lernen, PHP und SQL kann ich gut, dann kann ich beitragen, wenn man nur die Zeit hätte]

@yubiuser Vielleicht können sie das querverlinken, dann kann sein Fix direkt als Fix für diese Issue angezeigt werden.

yubiuser · July 20, 2020, 1:50pm

github.com/pi-hole/web

Audit log buttons adds to whitelist on v5.1.1 and produced lighttpd errors

opened 06:11PM - 22 Jun 20 UTC

closed 06:56AM - 10 Aug 20 UTC

yubiuser

Bug Bugfix in progress

**In raising this issue, I confirm the following:** - [x] I have read and und…erstood the [contributors guide](https://github.com/pi-hole/AdminLTE/blob/master/CONTRIBUTING.md). - [x] The issue I am reporting can be *replicated*. - [x] The issue I am reporting isn't a duplicate (see [FAQs](https://github.com/pi-hole/pi-hole/wiki/FAQs), [closed issues](https://github.com/pi-hole/AdminLTE/issues?utf8=%E2%9C%93&q=is%3Aissue%20is%3Aclosed%20), and [open issues](https://github.com/pi-hole/AdminLTE/issues)). **How familiar are you with the the source code relevant to this issue?:** 1 --- **Expected behaviour:** Click on "Audit" button on audit log should add the domain to the audit log (`domain_audit` table) **Actual behaviour:** Click on "Audit" button on audit log does not add the domain to the audit log (`domain_audit` table) and produces error in `var/log/lighttpd/error.log` ``` 2020-06-22 19:54:14: (mod_fastcgi.c.421) FastCGI-stderr: PHP Notice: Undefined variable: type in /var/www/html/admin/scripts/pi-hole/php/groups.php on line 513 2020-06-22 19:54:14: (mod_fastcgi.c.421) FastCGI-stderr: PHP Notice: Undefined variable: type in /var/www/html/admin/scripts/pi-hole/php/groups.php on line 513 2020-06-22 19:54:15: (mod_fastcgi.c.421) FastCGI-stderr: PHP Notice: Undefined variable: type in /var/www/html/admin/scripts/pi-hole/php/groups.php on line 476 2020-06-22 19:54:15: (mod_fastcgi.c.421) FastCGI-stderr: PHP Notice: Undefined index: type in /var/www/html/admin/scripts/pi-hole/php/groups.php on line 507 2020-06-22 19:54:15: (mod_fastcgi.c.421) FastCGI-stderr: PHP Notice: Undefined variable: type in /var/www/html/admin/scripts/pi-hole/php/groups.php on line 513 2020-06-22 19:54:15: (mod_fastcgi.c.421) FastCGI-stderr: PHP Notice: Undefined variable: type in /var/www/html/admin/scripts/pi-hole/php/groups.php on line 513 2020-06-22 19:54:16: (mod_fastcgi.c.421) FastCGI-stderr: PHP Notice: Undefined variable: type in /var/www/html/admin/scripts/pi-hole/php/groups.php on line 476 2020-06-22 19:54:16: (mod_fastcgi.c.421) FastCGI-stderr: PHP Notice: Undefined index: type in /var/www/html/admin/scripts/pi-hole/php/groups.php on line 507 ``` **Steps to reproduce:** ``` nanopi@nanopi:~$ pihole -v Pi-hole version is development v5.0-105-g3aaf9d8 (Latest: v5.0) AdminLTE version is devel v5.0-395-g536ecd69 (Latest: v5.0) FTL version is development vDev-336d72c (Latest: v5.0) ``` Click on "Audit" in the audit log page. **Troubleshooting undertaken, and/or other relevant information:** There was a similar issue before that was fixed before v5.0 was released. Might be a regression. https://github.com/pi-hole/AdminLTE/issues/1139

DL6ER · July 20, 2020, 8:08pm

So, bitte den Fix probieren:

pihole checkout web fix/audit_log

github.com/pi-hole/AdminLTE

Fix audit log button

pi-hole:release/v5.1.1 ← pi-hole:fix/audit_log

opened 08:07PM - 20 Jul 20 UTC

DL6ER

+48 -1

**By submitting this pull request, I confirm the following:** - [X] I have r…ead and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md), as well as this entire template. - [X] I have made only one major change in my proposed changes. - [X] I have commented my proposed changes within the code. - [X] I have tested my proposed changes, and have included unit tests where possible. - [X] I am willing to help maintain this change if there are issues with it later. - [X] I give this submission freely and claim no ownership. - [X] It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1) - [X] I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html)) --- **What does this PR aim to accomplish?:** Fix audit log feature #1470 https://github.com/pi-hole/pi-hole/issues/3552 **How does this PR accomplish the above?:** Add missing action to add domains to the audit log table. **What documentation changes (if any) are needed to support this PR?:** None

yubiuser · July 20, 2020, 8:25pm

Funktioniert bei mir.

Keine lighttpd Fehler mehr, Domains landen im Auditlog und nicht auf einer White/Blackliste.

peneu76 · July 27, 2020, 3:16am

Ich warte auf die nächste Version.

Bis dahin weiter meine Listen in Ordnung bringen und aufräumen. Bisher hat es sich gelohnt =)

  [i] Number of gravity domains: 624620 (287298 unique domains)
  [i] Number of exact blacklisted domains: 0
  [i] Number of regex blacklist filters: 149
  [i] Number of exact whitelisted domains: 2
  [i] Number of regex whitelist filters: 10

peneu76 · August 5, 2020, 1:23am

Gibt es schon einen Zeitplan für die nächste Version bzw. eine Version mit funktionierendem Audit Button?