API 6.0 GET /info/version

General Beta 6.0
1

Hello, I just did a Pi-hole -up on my v6 instance plus server reboot but when I query the /info/version API it still shows the previous version.

{
    "version": {
        "core": {
            "local": {
                "version": "v5.17.1-265-gebb0db0a",
                "branch": "development-v6",
                "hash": "ebb0db0a"
            },
            "remote": {
                "version": "v5.17.3",
                "hash": "ebb0db0a"
            }
        },
        "web": {
            "local": {
                "version": "v5.19-641-g9f04f7ab",
                "branch": "development-v6",
                "hash": "9f04f7ab"
            },
            "remote": {
                "version": "v5.21",
                "hash": "9f04f7ab"
            }
        },
        "ftl": {
            "local": {
                "hash": "806d6086",
                "branch": "development-v6",
                "version": "vDev-806d608",
                "date": "2024-01-13 20:44:39 +0100"
            },
            "remote": {
                "version": "v5.24",
                "hash": "806d6086"
            }
        },
        "docker": {
            "local": null,
            "remote": null
        }
    },
    "took": 0.00015687942504882812
}
2

Desktop shows that it is updated.

image
image996×108 12.2 KB

4

Have a look at the hashes. They are the same for local and remote, you are using the latest versions.

5

Thank you, but shouldn't the local:version also be updated to reflect that ?

6

They were updated:

image
image521×129 3.95 KB

7

There is an inconsistency about how the remote version is sourced:

As you can see, we are getting the remove version by looking the tag of the last release - completely neglecting any possible deviating local branch.

This will never match the local version for branch != master.

I don't think there is a similar "descriptive version" we could source from Github so maybe we should set local/remote versions to null if branch != master to emphasize the comparison needing to be done on a hash-basis.

8

Thanks.

9

Screenshot from 2024-01-15 20-58-08
Screenshot from 2024-01-15 20-58-08566×502 29 KB

The remaining bit for discussion is if we should set .local.version to null as well in this context (even when it is correct, it may not be very helpful)

1 Like
10

I think it's fine to keep it for now. It gives at least some indication at which point the custom branch diverged.

Add:
And having a lot of null in the version information makes the impression something might be wrong.

1 Like