Adjustable height of DHCP and Static Leases tables in settings

fake_immunity · January 4, 2022, 4:12pm

Hello,

The DHCP and Static Leases tables visible under settings, DHCP by default have a max height of 200px and show 4 entries. This becomes difficult to resize and an i cannot find a setting anywhere that would allow resizing of this

the setting can be edited in /scripts/pi-hole/js/settings.js by changing the value of scrollY at line 240 and 266 for the DHCP and static lease tables respectively. I have mine set to 2000px just so it shows all of my entries without scrolling the small boxes.

Given that other settings can be edited in the setupVars.conf file is there scope or interest for having an option to adjusts this from the web interface or via setupVars.conf?

yubiuser · January 4, 2022, 7:16pm

There is already a PR that will modify the DHCP tables in a way that they look like all other tables and include pagination.

github.com/pi-hole/AdminLTE

Tweak DHCP datatables

pi-hole:devel ← Moonlight63:tweak/DHCP-datatables

opened 04:00AM - 01 Jan 22 UTC

Moonlight63

+30 -14

**By submitting this pull request, I confirm the following:** `{please fill any …appropriate checkboxes, e.g: [X]}` `{Please ensure that your pull request is for the 'devel' branch!}` - [X] I have read and understood the [contributors guide](https://github.com/pi-hole/AdminLTE/blob/master/CONTRIBUTING.md), as well as this entire template. - [X] I have made only one major change in my proposed changes. - [X] I have commented my proposed changes within the code. - [X] I have tested my proposed changes. - [X] I am willing to help maintain this change if there are issues with it later. - [X] I give this submission freely and claim no ownership. - [X] It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1) - [X] I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html)) - [X] I have Signed Off all commits. ([`git commit --signoff`](https://git-scm.com/docs/git-commit#Documentation/git-commit.txt---signoff)) --- **What does this PR aim to accomplish?:** Brings the DHCP page in settings lin line with the datatables everywhere else in (such as DNS records and Groups). **How does this PR accomplish the above?:** By using the same datatable configuration as is used everywhere else. **What documentation changes (if any) are needed to support this PR?:** None

yubiuser · January 5, 2022, 7:02pm

@fake_immunity

The PR has been released. Can we assume the feature request is fulfilled?

fake_immunity · January 5, 2022, 7:49pm

Yep - just tried it - works great

system · July 4, 2022, 7:49pm

This topic was automatically closed 180 days after the last reply. New replies are no longer allowed.