mlopez
February 10, 2021, 2:21am
1
It would be useful to have in the List of configured adlists a column with the number (quantity) of domains (and size?) added by every list.
Regards!
At the moment you see the number of domains if you run a gravity update (pihole -g) or via the web interface. But likely there will be more information in the webinterface in the future:
So, bitte testen und ich freue mich über Rückmeldungen:
pihole checkout core new/gravity_adlist_infos
pihole checkout web new/gravity_adlist_infos
Dieser Versuch sollte möglichst Touchscreen-kompatibel sein. Weitere Infos zu den jeweiligen Listen gibt es wenn man auf das farbige Icon klickt:
[Screenshot from 2020-12-27 20-50-41]
Ich habe die Listen nun auch zu klickbaren Links umgewandelt, damit man schneller nachschauen kann, wieso eine Liste nicht funktioniert, z.B. in diesem Fall:
[Scree…
pi-hole:devel ← pi-hole:new/gravity_adlist_infos
opened 07:11AM - 28 Dec 20 UTC
**By submitting this pull request, I confirm the following:**
- [X] I have r… ead and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md), as well as this entire template.
- [X] I have made only one major change in my proposed changes.
- [X] I have commented my proposed changes within the code.
- [X] I have tested my proposed changes, and have included unit tests where possible.
- [X] I am willing to help maintain this change if there are issues with it later.
- [X] I give this submission freely and claim no ownership.
- [X] It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1)
- [X] I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html))
---
**What does this PR aim to accomplish?:**
Add more details to adlist table, exemplary screenshots:
Local lists do not get a link as they are not available for distant clients:
**How does this PR accomplish the above?:**
Parse new data in the `gravity.db:adlist` table stored there by https://github.com/pi-hole/pi-hole/pull/3951
**What documentation changes (if any) are needed to support this PR?:**
None
pi-hole:development ← pi-hole:new/gravity_adlist_infos
opened 07:10AM - 28 Dec 20 UTC
**By submitting this pull request, I confirm the following:**
- [X] I have r… ead and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md), as well as this entire template.
- [X] I have made only one major change in my proposed changes.
- [X] I have commented my proposed changes within the code.
- [X] I have tested my proposed changes, and have included unit tests where possible.
- [X] I am willing to help maintain this change if there are issues with it later.
- [X] I give this submission freely and claim no ownership.
- [X] It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1)
- [X] I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html))
---
**What does this PR aim to accomplish?:**
Store more gravity details in gravity.db adlist table for user display on the web interface
**How does this PR accomplish the above?:**
Store status of downloaded list (downloaded, using cache, some error,…) and number of (in-)valid domains on this list in the gravity database. This updates the gravity database to version 14.
**What documentation changes (if any) are needed to support this PR?:**
Gravity database schema changes, this needs to be accounted for in https://docs.pi-hole.net/database/gravity/groups/ in a follow-up PR.
1 Like
jfb
May 2, 2021, 1:21pm
3
I'll mark this as implemented in Pi-hole web V5.5.
pi-hole:devel ← pi-hole:new/gravity_adlist_infos
opened 07:11AM - 28 Dec 20 UTC
**By submitting this pull request, I confirm the following:**
- [X] I have r… ead and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md), as well as this entire template.
- [X] I have made only one major change in my proposed changes.
- [X] I have commented my proposed changes within the code.
- [X] I have tested my proposed changes, and have included unit tests where possible.
- [X] I am willing to help maintain this change if there are issues with it later.
- [X] I give this submission freely and claim no ownership.
- [X] It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1)
- [X] I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html))
---
**What does this PR aim to accomplish?:**
Add more details to adlist table, exemplary screenshots:
Local lists do not get a link as they are not available for distant clients:
**How does this PR accomplish the above?:**
Parse new data in the `gravity.db:adlist` table stored there by https://github.com/pi-hole/pi-hole/pull/3951
**What documentation changes (if any) are needed to support this PR?:**
None
system
October 29, 2021, 1:21pm
4
This topic was automatically closed 180 days after the last reply. New replies are no longer allowed.