Active Client number is wrong on admin page

Clarence_Perry · October 21, 2023, 1:14pm

New install of Ubuntu 22.04.3 LTS and Pi-hole Beta 6 on an older IBM Think server I had laying around. It been running for less than 24 hours, but is setup as the primary DNS on my network.

I used these directions to install https://pi-hole.net/blog/2023/10/09/pi-hole-v6-beta-testing/#page-content

I noticed this morning when checking the /admin page that the Active Client # was 621! When I click the link to see where all the clients came from, /admin/network, there are only 29 Active Clients listed.

Debug Token-https://tricorder.pi-hole.net/59kd99rV/

DL6ER · October 21, 2023, 4:35pm

Ah yes, I see this is indeed wrong on the dashboard. FTL reports both the total (ever seen) and active (issued at least one query in the past 24 hours) number of clients and the web interface actually shows the total number here. It's probably a good idea to just show both like
Screenshot from 2023-10-21 18-35-46

DL6ER · October 21, 2023, 4:48pm

github.com/pi-hole/web

Show active instead of clients-ever-seen on the dashboard

pi-hole:development-v6 ← pi-hole:fix/active_clients

opened 04:46PM - 21 Oct 23 UTC

DL6ER

+4 -1

# What does this implement/fix? Show *active* clients instead of *clients-eve…r-seen* on the dashboard: ![Screenshot from 2023-10-21 18-45-55](https://github.com/pi-hole/web/assets/16748619/1d57b999-ef6d-4bae-945b-5614472789c6) When the two numbers are different, show both ![image](https://github.com/pi-hole/web/assets/16748619/459cc0f4-9c9a-4de8-837a-032d640a4d48) This PR depends on the corresponding FTL branch being checked out: https://github.com/pi-hole/FTL/pull/1688 **Related issue or feature (if applicable):** N/A **Pull request in [docs](https://github.com/pi-hole/docs) with documentation (if applicable):** N/A --- **By submitting this pull request, I confirm the following:** 1. I have read and understood the [contributors guide](https://docs.pi-hole.net/guides/github/contributing/), as well as this entire template. I understand which branch to base my commits and Pull Requests against. 2. I have commented my proposed changes within the code. 3. I am willing to help maintain this change if there are issues with it later. 4. It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1) 5. I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html)) ## Checklist: - [x] The code change is tested and works locally. - [x] I based my code and PRs against the repositories `developmental` branch. - [x] I [signed off](https://docs.pi-hole.net/guides/github/how-to-signoff/) all commits. Pi-hole enforces the [DCO](https://docs.pi-hole.net/guides/github/dco/) for all contributions - [x] I [signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) all my commits. Pi-hole requires signatures to verify authorship - [x] I have read the above and my PR is ready for review.

github.com/pi-hole/FTL

Include number of active clients in summary

pi-hole:development-v6 ← pi-hole:tweak/active_clients

opened 04:47PM - 21 Oct 23 UTC

DL6ER

+18 -0

# What does this implement/fix? Include number of active clients in the respo…nse of `GET /api/stats/summary` Needed for https://github.com/pi-hole/web/pull/2769 **Related issue or feature (if applicable):** N/A **Pull request in [docs](https://github.com/pi-hole/docs) with documentation (if applicable):** N/A --- **By submitting this pull request, I confirm the following:** 1. I have read and understood the [contributors guide](https://docs.pi-hole.net/guides/github/contributing/), as well as this entire template. I understand which branch to base my commits and Pull Requests against. 2. I have commented my proposed changes within the code. 3. I am willing to help maintain this change if there are issues with it later. 4. It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1) 5. I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html)) ## Checklist: - [x] The code change is tested and works locally. - [x] I based my code and PRs against the repositories `developmental` branch. - [x] I [signed off](https://docs.pi-hole.net/guides/github/how-to-signoff/) all commits. Pi-hole enforces the [DCO](https://docs.pi-hole.net/guides/github/dco/) for all contributions - [x] I [signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) all my commits. Pi-hole requires signatures to verify authorship - [x] I have read the above and my PR is ready for review.