About pihole updatechecker

secooonder · September 22, 2019, 6:11pm

Hello

root@johnywalker:/var/log# pihole -v
Pi-hole version is v4.3.2 (Latest: v4.3.2)
AdminLTE version is v4.3.2 (Latest: v4.3.2)
FTL version is v4.3.1 (Latest: v4.3.1)

more /etc/cron.d/pihole

...
...
Pi-hole: Grab local version and branch every 10 minutes
*/10 * * * * root PATH="$PATH:/usr/local/bin/" pihole updatechecker local > /var/log/see.log

Pi-hole: Grab remote version every 24 hours
35 18 * * * root PATH="$PATH:/usr/local/bin/" pihole updatechecker remote
@reboot root PATH="$PATH:/usr/local/bin/" pihole updatechecker remote reboot

i never understood "pihole updatechecker local/remote" ,although i read a lot of articles.

pihole updatechecker local read ;

root@johnywalker:/var/log# more /etc/pihole/localbranches
master master master
root@johnywalker:/var/log# more /etc/pihole/localversions
v4.3.2-0-ge41c4b5 v4.3.2-0-g38d8e77 v4.3.1

pihole updatechecker remote read ;

root@johnywalker:/var/log# more /etc/pihole/GitHubVersions
v4.3.2 v4.3.2 v4.3.1

i know above it.But What is happening these command in cron ?

i add pihole updatechecker local> /var/log/see.log ,but i can not see log .(This log file is empty).

if the cron checking for update, i did not took an information" out of date". ??
how do I know that all my configuration files are not going to github.every 10 minutes? is it safe ?
is it necessary cron ?

Thank you ver much for your help

secooonder · September 23, 2019, 5:19am

Please help me

jfb · September 23, 2019, 5:47am

You can read the code. The function is called here:

github.com

pi-hole/pi-hole/blob/master/pihole#L373


      
            elif grep -q "BLOCKING_ENABLED=true" /etc/pihole/setupVars.conf;  then
              # Configs are set
              case "${1}" in
                "web") echo "$port";;
                *) echo -e "  ${TICK} Pi-hole blocking is enabled";;
              esac
            else
              # No configs were found
              case "${1}" in
                "web") echo -2;;
                *) echo -e "  ${INFO} Pi-hole blocking will be enabled";;
              esac
              # Enable blocking
              "${PI_HOLE_BIN_DIR}"/pihole enable
            fi
          exit 0
          }
          
          tailFunc() {
            # Warn user if Pi-hole's logging is disabled
            local logging_enabled=$(grep -c "^log-queries" /etc/dnsmasq.d/01-pihole.conf)

And this is the script that runs.

github.com

pi-hole/pi-hole/blob/master/advanced/Scripts/updatecheck.sh#L6


      
          #!/usr/bin/env bash
          # Pi-hole: A black hole for Internet advertisements
          # (c) 2017 Pi-hole, LLC (https://pi-hole.net)
          # Network-wide ad blocking via your own hardware.
          #
          # Checks for local or remote versions and branches
          #
          # This file is copyright under the latest version of the EUPL.
          # Please see LICENSE file for your rights under this license.
          
          function get_local_branch() {
              # Return active branch
              cd "${1}" 2> /dev/null || return 1
              git rev-parse --abbrev-ref HEAD || return 1
          }

Yes. If it were not necessary, it would not be included in the code.

secooonder · October 26, 2019, 3:05pm

jfb thank you.
can I ask one more question.
I am so sorry for my question.

*/10 * * * * root PATH="$PATH:/usr/local/bin/"  pihole updatechecker local

Pi-hole: Grab remote version every 24 hours
35 18 * * * root PATH="$PATH:/usr/local/bin/"  pihole updatechecker remote

But i can not understand two line.

pihole update checker local tested my version ? is it true ?
pihole updatechecker local read ;

root@johnywalker:/var/log# more /etc/pihole/localbranches
master master master
root@johnywalker:/var/log# more /etc/pihole/localversions
v4.3.2-0-ge41c4b5 v4.3.2-0-g38d8e77 v4.3.1
if my version is old,what did pihole do ?
Does automatic update? is pihole tell me ? Which ?

automatic update sometimes stops working?
2)
pihole updatechecker remote read ;

root@johnywalker:/var/log# more /etc/pihole/GitHubVersions
v4.3.2 v4.3.2 v4.3.1
is it true ?

what happens after pihole read it ?Does automatic update? is pihole tell me ? Which ?

Thank you very much

DanSchaper · October 26, 2019, 4:07pm

If there is an update then the web interface will note that in the version display. pihole -v will also note that there is an update available. Pi-hole does not auto update since that is a very bad thing to do.

jfb · October 26, 2019, 4:54pm

As noted, there is no automatic update feature. You should read the release notes for a new version and then decide if you want to install it, then the update is manual with pihole -up

When there is a newer version available, then the version information at the bottom of the dashboard turns red to alert you that there is a newer version. There are generally also release announcements from the developers on this site, GitHub and Reddit.

secooonder · October 27, 2019, 2:11pm

DanSchaper and jfb

The problem is solved.

Thank you very much for your help