-2 Domains on Blocklist (after updating pihole)

TheME · October 24, 2024, 7:04pm

Sometimes the dashboard just shows -2 domains on the blocklist.
Nevertheless, the blocklist seems to be active, because blocking works as expected.

I had updated pihole some hours before, but didn't notice the behavior right away.
The update log seems to have been cleared by DietPi in the meantime.

running pihole -g fixes that, but unfortunately this is not the first time I have noticed this.

https://tricorder.pi-hole.net/oosDECbs/

buntspexxt · October 24, 2024, 7:11pm

The last time this happened to me was before my SD card became defective.

rdwebdesign · October 24, 2024, 8:05pm

@DL6ER, I need your help to correct me if I'm wrong.

I think this happens when the gravityDB_count() function encounters a problem counting the number of blocked domains and returns the constant DB_FAILED (which has a value of -2). Then the javascript code receives this value and show it.

rdwebdesign · October 24, 2024, 10:27pm

This should fix the issue:

github.com/pi-hole/web

Fix gravity count when FTL fails to return this value

pi-hole:development ← pi-hole:fix/gravity_no_count

opened 10:26PM - 24 Oct 24 UTC

rdwebdesign

+2 -1

### What does this PR aim to accomplish? Fixes the `-2 Domains on the Lists` …issue. ### How does this PR accomplish the above? When FTL fails to count the number of domains on the lists, the value `-2` is returned, but this value should not be printed. This PR shows `0` in this case. ### Link documentation PRs if any are needed to support this PR: none --- **By submitting this pull request, I confirm the following:** 1. I have read and understood the [contributors guide](https://docs.pi-hole.net/guides/github/contributing/), as well as this entire template. I understand which branch to base my commits and Pull Requests against. 2. I have commented my proposed changes within the code and I have tested my changes. 3. I am willing to help maintain this change if there are issues with it later. 4. It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1) 5. I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html)) 6. I have checked that another pull request for this purpose does not exist. 7. I have considered, and confirmed that this submission will be valuable to others. 8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer. 9. I give this submission freely, and claim no ownership to its content. --- - [x] I have read the above and my PR is ready for review. *Check this box to confirm*

DL6ER · October 25, 2024, 6:40pm

Yes, the question here is - as so often - the Why?

Looking at @TheME's debug token, /var/log/pihole/FTL.log is completely empty which is really odd as the mentioned function gravityDB_count() does log errors on each possible way that leads to -2

TheME · October 25, 2024, 7:19pm

This is probably because DietPi uses RAMlog and the logs are cleared every hour by default.
I have now changed the setting to store the logs on disk.