Usage of dnsmasq's `--user` option does not chown db-shm and db-wal files on first launch

DL6ER · May 20, 2024, 5:37pm

Oh yes, it indeed makes more sense to always try to chown. I guess we all have been carried away from your enthusiastic confirmation

github.com/pi-hole/FTL

Fix chown of aux. database files

pi-hole:development-v6 ← pi-hole:fix/database_aux_files

opened 05:37PM - 20 May 24 UTC

DL6ER

+36 -27

# What does this implement/fix? Always try to `chown` auxiliary database file…s, not only when `chown` of the database files itself failed. I simplified and re-arranged the code to reduce the nesting depth by up to two levels, making such issues easier to detect visually. --- **Related issue or feature (if applicable):** N/A **Pull request in [docs](https://github.com/pi-hole/docs) with documentation (if applicable):** N/A --- **By submitting this pull request, I confirm the following:** 1. I have read and understood the [contributors guide](https://docs.pi-hole.net/guides/github/contributing/), as well as this entire template. I understand which branch to base my commits and Pull Requests against. 2. I have commented my proposed changes within the code. 3. I am willing to help maintain this change if there are issues with it later. 4. It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1) 5. I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html)) ## Checklist: - [x] The code change is tested and works locally. - [x] I based my code and PRs against the repositories `developmental` branch. - [x] I [signed off](https://docs.pi-hole.net/guides/github/how-to-signoff/) all commits. Pi-hole enforces the [DCO](https://docs.pi-hole.net/guides/github/dco/) for all contributions - [x] I [signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) all my commits. Pi-hole requires signatures to verify authorship - [x] I have read the above and my PR is ready for review.