Hi Guys,
Can I suggest that the wording on:
the above page
in the "Use Conditional Forwarding" section
over the IP Text input box
be changed from
"IP of your router"
to
"IP of your DHCP Server"
I took the title of the textbox to be the definitive requirement and as my DHCP server (on a Domain controller) does not run on my router (remote access machine) I ended up pointing at the wrong IP address.
The change would clarify the usage.
Many thanks in advance
DL6ER
January 18, 2020, 4:31pm
2
I'm not convinced. Pi-hole is a commonly used project for users never having working with networking, it may be even their first Raspberry Pi or even their first Linux project. It is not all that likely that they know what a DNS server is. However, they typically know what a router is.
That's corect.IP of your router / DHCP server
Why not "IP of your router / Authoritative DNS server" then? That's the key item, the DNS server that is authoritative for the zone. Doesn't have to be a router or a DHCP server.
1 Like
icarson
January 18, 2020, 11:04pm
7
@DanSchaper I think your suggestion best meets my concerns over the wording. The key to my solution was to ensure that the IP of the Domain Primary DNS server was used (which was also the DHCP Server)
Okay, Router / Zone DNS server may be better and less "technical"?
Has been implemented with the improved conditional forwarding section in v5.1
pi-hole:devel ← pi-hole:new/rev-server
opened 07:27AM - 09 Apr 20 UTC
**By submitting this pull request, I confirm the following:**
- [X] I have r… ead and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md), as well as this entire template.
- [X] I have made only one major change in my proposed changes.
- [X] I have commented my proposed changes within the code.
- [X] I have tested my proposed changes, and have included unit tests where possible.
- [X] I am willing to help maintain this change if there are issues with it later.
- [X] I give this submission freely and claim no ownership.
- [X] It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1)
- [X] I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html))
---
**What does this PR aim to accomplish?:**
"Conditional forwarding" can be used to tell FTL to send queries to local devices (either with a local domain) and PTR requests for private ranges to a dedicated device (typically the router of the network) instead of the configured upstreams.
While this works for most users, it is not very flexible, as it implies three severe limitations (assuming the router is `10.1.2.3`):
- It is limited to IPv4
- It automatically assumes a Class D network. i.e. `10.1.2.0/24`. This is often correct (typically for `192.168.x.0/24` networks, but may also be wrong!
- It requires the subnet to be the same Class D network the router is in (this may be a fair assumption, however).
**How does this PR accomplish the above?:**
This PR aims at making conditional forwarding more flexible.
- It supports IPv4 and IPv6
- It adds a dedicated box for the local subnet to be used (can be, e.g., `10.0.0.0/8` in above's example)
- The router can be specified independently of the subnet, it could even be a foreign device (like "ask `13.225.3.2` for all IPs in range `10.0.0.0/8`).
**This feature is intended for Pi-hole v5.1 to ensure we have proper time for testing once it hits `development`**
**What documentation changes (if any) are needed to support this PR?:**
It has to be checked whether/where we document conditional forwarding.
It now stats "IP address of your DHCP server (router)"