- setupVars.conf:
As per instructions, when setting up DNScrypt, the SERVER setting(s) are commented out. Any update (pihole -up) seems to remove commented lines, but variables NOT known to pihole are left alone. Example: I've added a setting ALLOW_WHITELISTING=true, this to manipulate the availability of the whitelist button in the blockpage. This variable survives any configuration change / upgrade. The code for this in /var/www/html/pihole/index.php is:
<a class='safe33' href='javascript:history.back()'>Go back</a>
<?php if((isset($setupVars["ALLOW_WHITELISTING"])) && ($setupVars["ALLOW_WHITELISTING"] == 1)){ ?>
<a class='safe33' id="whitelisting">Whitelist this page</a>
<?php } ?>
<a class='safe33' href='javascript:window.close()'>Close window</a>
Of course, this is lost during an upgrade. - /etc/dnsmasq.d configuration files:
I currently have 4 dnsmasq configuration files (not using DHCP). Maybe you could add these files, by name, to setupVars.conf, and get the appropriate settings from the configuration files e.g.
PIHOLE=/etc/dnsmasq.d/01-pihole.conf
DHCP=/etc/dnsmasq.d/???
WILDCARD=/etc/dnsmasq.d/03-pihole-wildcard.conf
DNSCRYPT=/etc/dnsmasq.d/04-dnscrypt.conf
DNSSEC=/etc/dnsmasq.d/05-dnssec.conf
This means you look for any DNSSEC settings in the appropriate file, look for SERVER settings in the DNScrypt file, even if DNScrypt isn't running. You're already doing that for the wildcard settings, except the filename is fixed (not opposed to that either, just need the naming convention).
For the SERVER settings, this means you need to leave the port number and separator alone, or allow this as valid input in the settings page!!!
I don't need the settings page, except maybe only once to determine the result of a setting on the settings page (e.g. bogus-priv comes from the option "never forward non-FQDNs", if I'm right)
This may also be in line with this pull request;
I didn't check this out yet, but there is competition out there. Sticking with pi-hole:slight_smile:, smarter developers...