Restore ability to add blacklists in bulk

yubiuser · February 16, 2020, 9:30am

With the latest changes both issues are resolved!

Chrome: Blacklist on first startup

Firefox:

yubiuser · February 16, 2020, 10:15am

@DL6ER
Could you apply the line break patch to 'Group management/Adlists' as well?

DL6ER · February 16, 2020, 3:46pm

Please try

pihole checkout web tweak/wrap_other_tables

yubiuser · February 16, 2020, 4:42pm

Working in firefox and chrome.

cyrus104 · March 16, 2020, 1:02pm

Do I need to checkout the weak/wrap_other_tables branch to get this to work?

I've tested with a space and with a carriage return but haven't gotten it work.

Thanks

DL6ER · March 31, 2020, 9:47pm

github.com/pi-hole/web

Allow space separated multiple items injection

pi-hole:release/v5.0 ← pi-hole:new/space-separated-item-injection

opened 07:12PM - 11 Feb 20 UTC

DL6ER

+68 -195

**By submitting this pull request, I confirm the following:** - [X] I have r…ead and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md), as well as this entire template. - [X] I have made only one major change in my proposed changes. - [X] I have commented my proposed changes within the code. - [X] I have tested my proposed changes, and have included unit tests where possible. - [X] I am willing to help maintain this change if there are issues with it later. - [X] I give this submission freely and claim no ownership. - [X] It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1) - [X] I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html)) --- **What does this PR aim to accomplish?:** Allow users to add multiple groups/clients/domains/adlists at once by space-separating them. All added items will receive the same comment (if specified). **Example 1** ![Screenshot from 2020-02-11 20-05-57](https://user-images.githubusercontent.com/16748619/74269873-84b9c400-4d0a-11ea-86f2-e7d11e576b45.png) resulting in: ![Screenshot from 2020-02-11 20-06-03](https://user-images.githubusercontent.com/16748619/74269878-85eaf100-4d0a-11ea-8a9f-c603638bab91.png) **Example 2** ![Screenshot from 2020-02-11 20-06-29](https://user-images.githubusercontent.com/16748619/74269838-753a7b00-4d0a-11ea-9d4e-1fd91bd46540.png) resulting in: ![Screenshot from 2020-02-11 20-06-41](https://user-images.githubusercontent.com/16748619/74269843-77043e80-4d0a-11ea-89bd-bdea7bcd19ca.png) Also, we remove the redundant list management from the settings page as this code was only partially migrated to the database backend (it was planed to be replace, anyway) and still uses CLI callbacks in the background. It is not needed any longer. I added a link to the new page so users will not be confused by a sudden absence of the settings tab. **How does this PR accomplish the above?:** Implement processing of space-separated items as individual entries. **What documentation changes (if any) are needed to support this PR?:** None

and

github.com/pi-hole/web

Add class "breakall" also to the code fields in the other tables.

pi-hole:release/v5.0 ← pi-hole:tweak/wrap_other_tables

opened 04:50PM - 16 Feb 20 UTC

DL6ER

+22 -3

**By submitting this pull request, I confirm the following:** - [X] I have r…ead and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md), as well as this entire template. - [X] I have made only one major change in my proposed changes. - [X] I have commented my proposed changes within the code. - [X] I have tested my proposed changes, and have included unit tests where possible. - [X] I am willing to help maintain this change if there are issues with it later. - [X] I give this submission freely and claim no ownership. - [X] It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1) - [X] I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html)) --- **What does this PR aim to accomplish?:** Enable wrapping of too long lines in the group management tables. **How does this PR accomplish the above?:** Add class `breakall` to all `<code>` tags in all tables. **What documentation changes (if any) are needed to support this PR?:** None

have been merged.

Please go back onto track using

pihole checkout web release/v5.0

Thanks for using the Pi-hole!