Pihole -up --check-only fails on FTL

Updated pihole with pihole -up, appears to update correctly

  [i] FTL Checks...

  [✓] Detected x86_64 architecture
  [i] Checking for existing FTL binary...
  [i] Latest FTL Binary already installed (v4.3.1). Confirming Checksum...
  [i] Checksum correct. No need to download!
...
Update Complete!

  Current Pi-hole version is v4.3.3
  Current AdminLTE version is v4.3.3
  Current FTL version is v4.3.1

Expected Behaviour:

pihole -up --check-only:

up to date / no update available (or whatever it should say)

Actual Behaviour:

edited /etc/resolv.conf to use a different dns

pihole -up --check-only

  [i] Checking for updates...
  [i] Pi-hole Core:	up to date
  [i] Web Interface:	up to date
curl: (22) The requested URL returned error: 404 Not Found
  [i] FTL:		update available

Thanks, can you run sudo bash -x /opt/pihole/update.sh and paste the output?

1 Like
sudo bash -x /opt/pihole/update.sh
[sudo] password for administrator:
+ readonly ADMIN_INTERFACE_GIT_URL=https://github.com/pi-hole/AdminLTE.git
+ ADMIN_INTERFACE_GIT_URL=https://github.com/pi-hole/AdminLTE.git
+ readonly ADMIN_INTERFACE_DIR=/var/www/html/admin
+ ADMIN_INTERFACE_DIR=/var/www/html/admin
+ readonly PI_HOLE_GIT_URL=https://github.com/pi-hole/pi-hole.git
+ PI_HOLE_GIT_URL=https://github.com/pi-hole/pi-hole.git
+ readonly PI_HOLE_FILES_DIR=/etc/.pihole
+ PI_HOLE_FILES_DIR=/etc/.pihole
+ PH_TEST=true
+ CHECK_ONLY=false
+ source '/etc/.pihole/automated install/basic-install.sh'
++ set -e
+++ cat
++ DNS_SERVERS='Google (ECS);8.8.8.8;8.8.4.4;2001:4860:4860:0:0:0:0:8888;2001:4860:4860:0:0:0:0:8844
OpenDNS (ECS);208.67.222.222;208.67.220.220;2620:119:35::35;2620:119:53::53
Level3;4.2.2.1;4.2.2.2;;
Comodo;8.26.56.26;8.20.247.20;;
DNS.WATCH;84.200.69.80;84.200.70.40;2001:1608:10:25:0:0:1c04:b12f;2001:1608:10:25:0:0:9249:d69b
Quad9 (filtered, DNSSEC);9.9.9.9;149.112.112.112;2620:fe::fe;2620:fe::9
Quad9 (unfiltered, no DNSSEC);9.9.9.10;149.112.112.10;2620:fe::10;2620:fe::fe:10
Quad9 (filtered + ECS);9.9.9.11;149.112.112.11;2620:fe::11;
Cloudflare;1.1.1.1;1.0.0.1;2606:4700:4700::1111;2606:4700:4700::1001'
++ installLogLoc=/etc/pihole/install.log
++ setupVars=/etc/pihole/setupVars.conf
++ lighttpdConfig=/etc/lighttpd/lighttpd.conf
++ coltable=/opt/pihole/COL_TABLE
++ webroot=/var/www/html
++ webInterfaceGitUrl=https://github.com/pi-hole/AdminLTE.git
++ webInterfaceDir=/var/www/html/admin
++ piholeGitUrl=https://github.com/pi-hole/pi-hole.git
++ PI_HOLE_LOCAL_REPO=/etc/.pihole
++ PI_HOLE_FILES=(chronometer list piholeDebug piholeLogFlush setupLCD update version gravity uninstall webpage)
++ PI_HOLE_INSTALL_DIR=/opt/pihole
++ PI_HOLE_CONFIG_DIR=/etc/pihole
++ PI_HOLE_BIN_DIR=/usr/local/bin
++ PI_HOLE_BLOCKPAGE_DIR=/var/www/html/pihole
++ useUpdateVars=false
++ adlistFile=/etc/pihole/adlists.list
++ regexFile=/etc/pihole/regex.list
++ IPV4_ADDRESS=
++ IPV6_ADDRESS=
++ QUERY_LOGGING=true
++ INSTALL_WEB_INTERFACE=true
++ PRIVACY_LEVEL=0
++ '[' -z root ']'
++ '[' -t 0 ']'
+++ stty size
++ screen_size='83 122'
++ printf -v rows %d 83
++ printf -v columns %d 122
++ r=41
++ c=61
++ r=41
++ c=70
++ skipSpaceCheck=false
++ reconfigure=false
++ runUnattended=false
++ INSTALL_WEB_SERVER=true
++ [[ -f /opt/pihole/COL_TABLE ]]
++ source /opt/pihole/COL_TABLE
+++ [[ -t 1 ]]
++++ tput colors
+++ [[ 256 -ge 8 ]]
+++ COL_BOLD=''
+++ COL_ULINE=''
+++ COL_NC=''
+++ COL_GRAY=''
+++ COL_RED=''
+++ COL_GREEN=''
+++ COL_YELLOW=''
+++ COL_BLUE=''
+++ COL_PURPLE=''
+++ COL_CYAN=''
+++ COL_WHITE=''
+++ COL_BLACK=''
+++ COL_LIGHT_BLUE=''
+++ COL_LIGHT_GREEN=''
+++ COL_LIGHT_CYAN=''
+++ COL_LIGHT_RED=''
+++ COL_URG_RED=''
+++ COL_LIGHT_PURPLE=''
+++ COL_BROWN=''
+++ COL_LIGHT_GRAY=''
+++ COL_DARK_GRAY=''
+++ TICK='[✓]'
+++ CROSS='[✗]'
+++ INFO='[i]'
+++ QST='[?]'
+++ DONE=' done!'
+++ OVER='\r'
++ counter=0
++ [[ true != true ]]
+ source /opt/pihole/COL_TABLE
++ [[ -t 1 ]]
+++ tput colors
++ [[ 256 -ge 8 ]]
++ COL_BOLD=''
++ COL_ULINE=''
++ COL_NC=''
++ COL_GRAY=''
++ COL_RED=''
++ COL_GREEN=''
++ COL_YELLOW=''
++ COL_BLUE=''
++ COL_PURPLE=''
++ COL_CYAN=''
++ COL_WHITE=''
++ COL_BLACK=''
++ COL_LIGHT_BLUE=''
++ COL_LIGHT_GREEN=''
++ COL_LIGHT_CYAN=''
++ COL_LIGHT_RED=''
++ COL_URG_RED=''
++ COL_LIGHT_PURPLE=''
++ COL_BROWN=''
++ COL_LIGHT_GRAY=''
++ COL_DARK_GRAY=''
++ TICK='[✓]'
++ CROSS='[✗]'
++ INFO='[i]'
++ QST='[?]'
++ DONE=' done!'
++ OVER='\r'
+ [[ '' == \-\-\c\h\e\c\k\-\o\n\l\y ]]
+ main
+ local 'basicError=\n  Unable to complete update, please contact Pi-hole Support'
+ local core_update
+ local web_update
+ local FTL_update
+ core_update=false
+ web_update=false
+ FTL_update=false
+ source /etc/pihole/setupVars.conf
++ BLOCKING_ENABLED=true
++ WEBPASSWORD=73ff5810ff4b1d4819bb45402a9a71e9621668633e06919e7163dd6ddfb67ba3
++ DNSMASQ_LISTENING=single
++ PIHOLE_DNS_3=176.103.130.130#53
++ PIHOLE_DNS_4=176.103.130.131#53
++ DNS_FQDN_REQUIRED=false
++ DNS_BOGUS_PRIV=false
++ DNSSEC=false
++ CONDITIONAL_FORWARDING=false
++ PIHOLE_INTERFACE=eno1
++ IPV4_ADDRESS=10.0.0.6/24
++ IPV6_ADDRESS=
++ PIHOLE_DNS_1=208.67.222.222
++ PIHOLE_DNS_2=208.67.220.220
++ QUERY_LOGGING=true
++ INSTALL_WEB_SERVER=true
++ INSTALL_WEB_INTERFACE=true
++ LIGHTTPD_ENABLED=true
+ is_repo /etc/.pihole
+ local directory=/etc/.pihole
+ local curdir
+ local rc
+ curdir=/home/administrator
+ [[ -d /etc/.pihole ]]
+ cd /etc/.pihole
+ git status --short
+ cd /home/administrator
+ return 0
+ echo -e '  [i] Checking for updates...'
  [i] Checking for updates...
+ GitCheckUpdateAvail /etc/.pihole
+ local directory
+ directory=/etc/.pihole
+ curdir=/home/administrator
+ cd /etc/.pihole
+ git fetch --quiet origin
++ git rev-parse '@{0}'
+ LOCAL=545b6605bc03dacc31e3f96d20beea5065c50bfe
++ git rev-parse '@{upstream}'
+ REMOTE=545b6605bc03dacc31e3f96d20beea5065c50bfe
+ [[ 40 == 0 ]]
+ [[ 40 == 0 ]]
+ cd /home/administrator
+ [[ 545b6605bc03dacc31e3f96d20beea5065c50bfe != \5\4\5\b\6\6\0\5\b\c\0\3\d\a\c\c\3\1\e\3\f\9\6\d\2\0\b\e\e\a\5\0\6\5\c\5\0\b\f\e ]]
+ return 1
+ core_update=false
+ echo -e '  [i] Pi-hole Core:\tup to date'
  [i] Pi-hole Core:	up to date
+ [[ true == true ]]
+ is_repo /var/www/html/admin
+ local directory=/var/www/html/admin
+ local curdir
+ local rc
+ curdir=/home/administrator
+ [[ -d /var/www/html/admin ]]
+ cd /var/www/html/admin
+ git status --short
+ cd /home/administrator
+ return 0
+ GitCheckUpdateAvail /var/www/html/admin
+ local directory
+ directory=/var/www/html/admin
+ curdir=/home/administrator
+ cd /var/www/html/admin
+ git fetch --quiet origin
++ git rev-parse '@{0}'
+ LOCAL=62f2ffc8394ac67880424644246eff8697b8e7e1
++ git rev-parse '@{upstream}'
+ REMOTE=62f2ffc8394ac67880424644246eff8697b8e7e1
+ [[ 40 == 0 ]]
+ [[ 40 == 0 ]]
+ cd /home/administrator
+ [[ 62f2ffc8394ac67880424644246eff8697b8e7e1 != \6\2\f\2\f\f\c\8\3\9\4\a\c\6\7\8\8\0\4\2\4\6\4\4\2\4\6\e\f\f\8\6\9\7\b\8\e\7\e\1 ]]
+ return 1
+ web_update=false
+ echo -e '  [i] Web Interface:\tup to date'
  [i] Web Interface:	up to date
+ FTLcheckUpdate
+ printf '  %b Checking for existing FTL binary...\n' '[i]'
+ local ftlLoc
++ which pihole-FTL
+ ftlLoc=/usr/bin/pihole-FTL
+ local ftlBranch
+ [[ -f /etc/pihole/ftlbranch ]]
+ ftlBranch=master
+ local binary
+ binary=
+ local remoteSha1
+ local localSha1
+ which dnsmasq
+ check_service_active dnsmasq
+ is_command systemctl
+ local check_command=systemctl
+ command -v systemctl
+ systemctl is-enabled dnsmasq
+ [[ ! master == \m\a\s\t\e\r ]]
+ [[ -n /usr/bin/pihole-FTL ]]
+ local FTLversion
++ /usr/bin/pihole-FTL tag
+ FTLversion=v4.3.1
+ local FTLreleaseData
+ local FTLlatesttag
++ curl -sI https://github.com/pi-hole/FTL/releases/latest
+ FTLreleaseData='HTTP/1.1 302 Found
Date: Mon, 24 Feb 2020 07:05:03 GMT
Content-Type: text/html; charset=utf-8
Server: GitHub.com
Status: 302 Found
Vary: X-PJAX, Accept-Encoding, Accept, X-Requested-With
Location: https://github.com/pi-hole/FTL/releases/tag/v4.3.1
Cache-Control: no-cache
Strict-Transport-Security: max-age=31536000; includeSubdomains; preload
X-Frame-Options: deny
X-Content-Type-Options: nosniff
X-XSS-Protection: 1; mode=block
Expect-CT: max-age=2592000, report-uri="https://api.github.com/_private/browser/errors"
Content-Security-Policy: default-src '\''none'\''; base-uri '\''self'\''; block-all-mixed-content; connect-src '\''self'\'' uploads.github.com www.githubstatus.com collector.githubapp.com api.github.com www.google-analytics.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com wss://live.github.com; font-src github.githubassets.com; form-action '\''self'\'' github.com gist.github.com; frame-ancestors '\''none'\''; frame-src render.githubusercontent.com; img-src '\''self'\'' data: github.githubassets.com identicons.github.com collector.githubapp.com github-cloud.s3.amazonaws.com *.githubusercontent.com; manifest-src '\''self'\''; media-src '\''none'\''; script-src github.githubassets.com; style-src '\''unsafe-inline'\'' github.githubassets.com
Age: 20
Set-Cookie: _gh_sess=A%2FYndK0GmfAxCX0OcCD2L8g6LYC%2Fv5Jk6COKekxhxCNIX7zisgqBsSKnE2NfVRKsvybkDM4y7e0NZZKcAiAhkPNohiGU7fYHLqyqQHoYhb3sT3psxsVGyoWFoiZ2XaUI6nmqHbPuo4of%2FN1fga9u80JopE8KheGSP94pU8PiA35hSstqPy2G%2FgWq4snrYo%2F9vuz2Jf8u80%2F3EBvkU8ZhWa4r5EBD6hH2rgwlrkJIw74%2Fu%2F8XIpxDjzSzIJN9xMiIq%2BVjFpjl9O6y4k6Dn2kHrw%3D%3D--TdHZYEQwn8oEh4mQ--cbtgDQfm3mrvvwpQbGe9Og%3D%3D; Path=/; HttpOnly; Secure
Set-Cookie: _octo=GH1.1.1630343051.1582527923; Path=/; Domain=github.com; Expires=Wed, 24 Feb 2021 07:05:23 GMT; Secure
Set-Cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 24 Feb 2021 07:05:23 GMT; HttpOnly; Secure
Content-Length: 116
X-GitHub-Request-Id: DF0C:31EBE:29BCA95:3E8951E:5E5375B3
'
++ grep Location
++ awk -F / '{print $NF}'
++ tr -d '\r\n'
+ FTLlatesttag=v4.3.1
+ [[ v4.3.1 != \v\4\.\3\.\1 ]]
+ printf '  %b Latest FTL Binary already installed (%s). Confirming Checksum...\n' '[i]' v4.3.1
++ curl -sSL --fail https://github.com/pi-hole/FTL/releases/download/v4.3.1/.sha1
++ cut -d ' ' -f 1
curl: (22) The requested URL returned error: 404 Not Found
+ remoteSha1=
++ cut -d ' ' -f 1
+++ which pihole-FTL
++ sha1sum /usr/bin/pihole-FTL
+ localSha1=3782c2b35ac10d384bbdc2db2d063cda0a306cf4
+ [[ '' != \3\7\8\2\c\2\b\3\5\a\c\1\0\d\3\8\4\b\b\d\c\2\d\b\2\d\0\6\3\c\d\a\0\a\3\0\6\c\f\4 ]]
+ printf '  %b Corruption detected...\n' '[i]'
+ return 0
+ FTL_update=true
+ echo -e '  [i] FTL:\t\tupdate available'
  [i] FTL:		update available
+ local ftlBranch
+ [[ -f /etc/pihole/ftlbranch ]]
+ ftlBranch=master
+ [[ ! master == \m\a\s\t\e\r ]]
+ [[ false == false ]]
+ [[ false == false ]]
+ [[ true == false ]]
+ [[ false == true ]]
+ [[ false == true ]]
+ [[ false == true ]]
+ [[ true == true ]]
+ echo ''

+ echo -e '  [i] FTL out of date, it will be updated by the installer.'
  [i] FTL out of date, it will be updated by the installer.
+ [[ true == true ]]
+ '/etc/.pihole/automated install/basic-install.sh' --reconfigure --unattended

  [✓] Root user check

        .;;,.
        .ccccc:,.
         :cccclll:.      ..,,
          :ccccclll.   ;ooodc
           'ccll:;ll .oooodc
             .;cll.;;looo:.
                 .. ','.
                .',,,,,,'.
              .',,,,,,,,,,.
            .',,,,,,,,,,,,....
          ....''',,,,,,,'.......
        .........  ....  .........
        ..........      ..........
        ..........      ..........
        .........  ....  .........
          ........,,,,,,,'......
            ....',,,,,,,,,,,,.
               .',,,,,,,,,'.
                .',,,,,,'.
                  ..'''.

  [i] Existing PHP installation detected : PHP version 7.3.14-1~deb10u1
  [i] Performing unattended setup, no whiptail dialogs will be displayed
  [✓] Disk space check
  [✓] Update local cache of available packages

  [✓] Checking apt-get for upgraded packages... up to date!

  [i] Installer Dependency checks...
  [✓] Checking for apt-utils
  [✓] Checking for dialog
  [✓] Checking for debconf
  [✓] Checking for dhcpcd5
  [✓] Checking for git
  [✓] Checking for iproute2
  [✓] Checking for whiptail

  [i] Performing reconfiguration, skipping download of local repos
  [✓] Resetting repository within /etc/.pihole...
  [✓] Resetting repository within /var/www/html/admin...
  [i] Main Dependency checks...
  [✓] Checking for cron
  [✓] Checking for curl
  [✓] Checking for dnsutils
  [✓] Checking for iputils-ping
  [✓] Checking for lsof
  [✓] Checking for netcat
  [✓] Checking for psmisc
  [✓] Checking for sudo
  [✓] Checking for unzip
  [✓] Checking for wget
  [✓] Checking for idn2
  [✓] Checking for sqlite3
  [✓] Checking for libcap2-bin
  [✓] Checking for dns-root-data
  [✓] Checking for resolvconf
  [✓] Checking for libcap2
  [✓] Checking for lighttpd
  [✓] Checking for php7.3-common
  [✓] Checking for php7.3-cgi
  [✓] Checking for php7.3-sqlite3

  [✓] Enabling lighttpd service to start on reboot...
  [✓] Checking for user 'pihole'

  [i] FTL Checks...

  [✓] Detected x86_64 architecture
  [i] Checking for existing FTL binary...
  [i] Latest FTL Binary already installed (v4.3.1). Confirming Checksum...
  [i] Checksum correct. No need to download!
  [✓] Checking for user 'pihole'
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
	LANGUAGE = "en_US:en",
	LC_ALL = (unset),
	LC_TERMINAL = "iTerm2",
	LC_CTYPE = "UTF-8",
	LANG = "en_US.UTF-8"
    are supported and installed on your system.
perl: warning: Falling back to a fallback locale ("en_US.UTF-8").
  [✓] Installing scripts from /etc/.pihole

  [i] Installing configs from /etc/.pihole...
  [i] Existing dnsmasq.conf found... it is not a Pi-hole file, leaving alone!
  [✓] Copying 01-pihole.conf to /etc/dnsmasq.d/01-pihole.conf

  [i] Installing blocking page...
  [✓] Creating directory for blocking page, and copying files
  [✗] Backing up index.lighttpd.html
      No default index.lighttpd.html file found... not backing up

  [✓] Installing sudoer file

  [✓] Installing latest Cron script

  [✓] Installing latest logrotate script
  [i] Backing up /etc/dnsmasq.conf to /etc/dnsmasq.conf.old
  [✓] man pages installed and database updated
  [i] Testing if systemd-resolved is enabled
  [i] Systemd-resolved is not enabled
  [✓] Restarting lighttpd service...
  [✓] Enabling lighttpd service to start on reboot...
  [i] Restarting services...
  [✓] Enabling pihole-FTL service to start on reboot...
  [✓] Restarting pihole-FTL service...
  [✓] Deleting existing list cache
  [i] Pi-hole blocking is enabled
  [✗] DNS resolution is currently unavailable
  [✓] DNS resolution is now available

  [i] Neutrino emissions detected...
  [✓] Pulling blocklist source list into range

  [i] Target: raw.githubusercontent.com (hosts)
  [✓] Status: Retrieval successful

  [i] Target: mirror1.malwaredomains.com (justdomains)
  [✓] Status: Retrieval successful

  [i] Target: sysctl.org (hosts)
  [✓] Status: Retrieval successful

  [i] Target: zeustracker.abuse.ch (blocklist.php?download=domainblocklist)
  [✓] Status: Retrieval successful

  [i] Target: s3.amazonaws.com (simple_tracking.txt)
  [✓] Status: Retrieval successful

  [i] Target: s3.amazonaws.com (simple_ad.txt)
  [✓] Status: Retrieval successful

  [i] Target: hosts-file.net (ad_servers.txt)
  [✓] Status: Retrieval successful

  [i] Target: dbl.oisd.nl (dbl.oisd.nl)
  [✓] Status: Retrieval successful

  [✓] Consolidating blocklists
  [✓] Extracting domains from blocklists
  [i] Number of domains being pulled in by gravity: 1149046
  [✓] Removing duplicate domains
  [i] Number of unique domains trapped in the Event Horizon: 1029492
  [i] Number of whitelisted domains: 4
  [i] Number of blacklisted domains: 5
  [i] Number of regex filters: 1
  [✓] Parsing domains into hosts format
  [✓] Cleaning up stray matter

  [✓] Force-reloading DNS service
  [✓] DNS service is running
  [✓] Pi-hole blocking is Enabled

  [i] The install log is located at: /etc/pihole/install.log
Update Complete!

  Current Pi-hole version is v4.3.3
  Current AdminLTE version is v4.3.3
  Current FTL version is v4.3.1
+ exit 1

Okay, so ${binary} is not being set so https://github.com/pi-hole/pi-hole/blob/545b6605bc03dacc31e3f96d20beea5065c50bfe/automated%20install/basic-install.sh#L2401 isn’t fully populated.

Will need to take a closer look tomorrow, nearing midnight here.

1 Like

Yep…

That needs to change to:

local funcOutput
funcOutput=$(get_binary_name) #Store output of get_binary_name here
local binary
binary="pihole-FTL${funcOutput##*pihole-FTL}" #binary name will be the last line of the output of get_binary_name (it always begins with pihole-FTL)

if FTLcheckUpdate "${binary}" > /dev/null; then

Binary isn’t getting set because binary isn’t being passed into FTLcheckUpdate as it would in a normal install run. This is already being done in release/v/5.0, we just missed it when cherry picking into release/v4.3.3

2 Likes

Have the same issue. Is there a fix for those who don’t want to upgrade to v5 as of now?

We will line up a 4.3.4 release at some point today.

But don’t worry too much, nothing is functionally affected.

1 Like

Yep, know that it’s not an issue to worry about, but you know, OCD… :smile:
Thanks for the quick reply and the upcoming fix.

1 Like

I noticed that there was an update, versions are now correct ?

administrator@homeautomation:~$ pihole -up --check-only
  [i] Checking for updates...
  [i] Pi-hole Core:	up to date
  [i] Web Interface:	up to date
  [i] FTL:		up to date

  [✓] Everything is up to date!

administrator@homeautomation:~$ pihole -v
  Pi-hole version is v4.3.5 (Latest: v4.3.5)
  AdminLTE version is v4.3.3 (Latest: v4.3.3)
  FTL version is v4.3.1 (Latest: v4.3.1)

That’s all the correct information.

Is everything behaving as it should for you?

Everything runs fine, thanks!

1 Like

This topic was automatically closed 21 days after the last reply. New replies are no longer allowed.