pi-Hole 5 - Dashboard keine Metriken mehr

yubiuser · June 3, 2020, 8:09pm

Just a not: it is not generally missing, it is just not installed if no webserver is installed during the installation:

pi-hole/pi-hole/blob/4d25f695267590b61a4061f9bb43448005d99b85/automated install/basic-install.sh#L237


      
              if "${PKG_MANAGER}" install --dry-run php > /dev/null 2>&1; then
                  phpVer="php"
              # fall back on the php5 packages
              else
                  phpVer="php5"
              fi
          else
              # Newer php is installed, its common, cgi & sqlite counterparts are deps
              phpVer="php$phpInsMajor.$phpInsMinor"
          fi
          # We also need the correct version for `php-sqlite` (which differs across distros)
          if "${PKG_MANAGER}" install --dry-run "${phpVer}-sqlite3" > /dev/null 2>&1; then
              phpSqlite="sqlite3"
          else
              phpSqlite="sqlite"
          fi
          # Since our install script is so large, we need several other programs to successfully get a machine provisioned
          # These programs are stored in an array so they can be looped through later
          INSTALLER_DEPS=(dhcpcd5 git "${iproute_pkg}" whiptail)
          # Pi-hole itself has several dependencies that also need to be installed
          PIHOLE_DEPS=(cron curl dnsutils iputils-ping lsof netcat psmisc sudo unzip wget idn2 sqlite3 libcap2-bin dns-root-data libcap2)

github.com

pi-hole/pi-hole/blob/4d25f695267590b61a4061f9bb43448005d99b85/automated install/basic-install.sh#L2592


      
          
                  # If no setting was found, default to 0
                  PRIVACY_LEVEL="${PRIVACY_LEVEL:-0}"
              fi
          fi
          # Clone/Update the repos
          clone_or_update_repos
          
          # Install the Core dependencies
          local dep_install_list=("${PIHOLE_DEPS[@]}")
          if [[ "${INSTALL_WEB_SERVER}" == true ]]; then
              # Install the Web dependencies
              dep_install_list+=("${PIHOLE_WEB_DEPS[@]}")
          fi
          
          install_dependent_packages "${dep_install_list[@]}"
          unset dep_install_list
          
          # On some systems, lighttpd is not enabled on first install. We need to enable it here if the user
          # has chosen to install the web interface, else the `LIGHTTPD_ENABLED` check will fail
          if [[ "${INSTALL_WEB_SERVER}" == true ]]; then

yubiuser · June 3, 2020, 8:12pm

War der vielleicht schon installiert, bevor du pihole installiert hast und du hast dann bei der Installation den Webserver nicht mehr mitinstalliert (weil der ja schon da war)?

c-hann · June 3, 2020, 8:18pm

Wrong decision to implement this, especially when it is actually needed. Therefore, this must be included, especially if a script is already offered for it.

Hat unser Mod ja grad geschrieben. Ist der Webserver bereits installiert, wird die Abfrage für die PHP-Dependencies geskipped ...

eviltrooper · June 3, 2020, 9:24pm

Ähhh ja ... er war schon installiert

yubiuser · June 4, 2020, 8:01am

Dann wäre das vielleicht etwas für den Bugreport: Pihole müsste nicht nur fragen, ob ein Webserver installiert ist werden sollte, sondern prüfen, ob der supportete Lighttpd installiert ist und dann entsprechend die dependencies prüfen.