DL6ER
January 29, 2024, 7:16pm
22
I did not see this anywhere, this was just my speculation as
lead to no clients showing up. If these are indeed all clients in your network, then my assumption was simply wrong.
jf62
January 29, 2024, 7:22pm
23
Actually 58 clients using pihole. I excluded just some which doing a lot of requests and not needed for me to seen in statistic
jf62
January 29, 2024, 7:24pm
24
So honestly, this kind of implementation of the new feature doesn't work for me like it is.
DL6ER
January 29, 2024, 7:30pm
25
Yeah, I get this. We need to find out why so we can get this fixed properly. So thanks for staying in tough with us about this issue. Can you make out specific entries in either excludeClients
or excludeDomains
causing this?
I still assume it may be the fritz.box
entry will all of your clients get a fritz.box
suffix. Please try them using anchors , like
^localhost$
^fritz.box$
^iobroker.fritz.box$
^SKY-IPTV-WZ.fritz.box$
^SKY-IPTV-GZ.fritz.box$
^DiskStation.fritz.box$
^pihole-6.fritz.box$
to ensure fritz.box
really matches only fritz.box
and not also xyz.fritz.box
(which does contain fritz,box
).
Hi, any chance you can make this branch visible again so I can snag a copy?
sudo pihole checkout ftl new/useWAL
sudo pihole-FTL --config database.useWAL false
My understanding is that WAL isn't supported over network filesystems. It would be nice to have this switch exposed in v6 for those mounting network (or weird-o) filesystems.
DL6ER
February 27, 2024, 5:51pm
29
It should be up. Which errors have been seeing when running the checkout
command?
Sorry, looks like I borked-up Git on my end. I can see new/useWAL
now.
Disabling SQLite write-ahead logging resolves my issue.
Is this something you plan to roll into v6?
Thanks for the assist!
D.
DL6ER
February 28, 2024, 4:47pm
32
Sure, it is awaiting review here:
pi-hole:development-v6
← pi-hole:new/useWAL
opened 03:18PM - 29 Jan 24 UTC
# What does this implement/fix?
Add new config option `database.useWAL` defau… lting to true making the use of the WAL journal optional for the on-disk query database. Reasons why this might be useful are given in the description of the new config option:
> **Should FTL enable Write-Ahead Log (WAL) mode for the on-disk query database (configured via files.database)?**
> It is recommended to leave this setting enabled for performance reasons. About the only reason to disable WAL mode is if you are experiencing specific issues with it, e.g., when using a database that is accessed from multiple hosts via a network share. When this setting is disabled, FTL will use SQLite3's default journal mode (rollback journal in DELETE mode).
This PR was initially triggered by [this Discourse thread](https://discourse.pi-hole.net/t/no-query-log-update-anymore-and-no-top-clients-all-and-blocked/67929), however, by now I think that WAL wasn't the issue here but specific user configuration I had not noticed before in the debug log.
---
**Related issue or feature (if applicable):** N/A
**Pull request in [docs](https://github.com/pi-hole/docs) with documentation (if applicable):** N/A
---
**By submitting this pull request, I confirm the following:**
1. I have read and understood the [contributors guide](https://docs.pi-hole.net/guides/github/contributing/), as well as this entire template. I understand which branch to base my commits and Pull Requests against.
2. I have commented my proposed changes within the code.
3. I am willing to help maintain this change if there are issues with it later.
4. It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1)
5. I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html))
## Checklist:
- [x] The code change is tested and works locally.
- [x] I based my code and PRs against the repositories `developmental` branch.
- [x] I [signed off](https://docs.pi-hole.net/guides/github/how-to-signoff/) all commits. Pi-hole enforces the [DCO](https://docs.pi-hole.net/guides/github/dco/) for all contributions
- [x] I [signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits) all my commits. Pi-hole requires signatures to verify authorship
- [x] I have read the above and my PR is ready for review.
1 Like
DL6ER
March 4, 2024, 6:41pm
33
It has been merged. Please go back to development-v6
soon.