New update FTL 5.5 / FATAL: Trying to access upstream ID -1, but maximum is 1024 / pihole-FTL.log ERRORS

DL6ER · January 19, 2021, 2:44pm

Thanks for the report. This is a regression from

github.com/pi-hole/FTL

Fix for Query Log filtering and memory optimizations

development ← fix/querylog_filtering

opened 02:35PM - 18 Jan 21 UTC

DL6ER

+205 -158

**By submitting this pull request, I confirm the following:** - [X] I have re…ad and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md). - [X] I have checked that [another pull request](https://github.com/pi-hole/FTL/pulls) for this purpose does not exist. - [X] I have considered, and confirmed that this submission will be valuable to others. - [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [X] I give this submission freely, and claim no ownership to its content. **How familiar are you with the codebase?:** ## 10 --- This PR fixes https://github.com/pi-hole/FTL/issues/1026 and https://github.com/pi-hole/FTL/issues/1027 by ensuring the first upstream destination is not a collector for all kinds of other queries. There was an ill assumption in the API code leading to a (much) too loose filtering. Furthermore, I added a bitfield to the `queriesData` struct to allow further simplification of the API code easing future maintainability (the same code will go into v6.0 so this still matters). While at it, I added a mechanism to ensure the size of memory objects does not change without us noticing (the CI will fail). The first commit optimized the internal datastructure FTL uses. By this, we were able to save 8 bytes of memory per query, oer client and per regex. On a typical setup with some clients, some regex and about 25,000 queries per day, this means a memory usage reduction of roughly 0.2 MB. This continues our efforts to fit Pi-hole into the smallest possible memory footprint (v5.0 already drastically reduced memory footprint due to using a B-tree for the blocking domains).

and can be safely ignored. However, I see it may be creating a flood of messages so we're going to get this fixed as soon as possible.