Network tab, hostnames not being updated

jacklul · May 14, 2020, 6:25pm

Is there any particular reason hostnames are not updated there?

While looking at the code network-table.c, lines 452-487 I can see hwaddr, interface and macVendor are the only fields that are being updated. Hostname isn't a thing that can't change and I think it would make sense to modify update query to include hostname as well.

DL6ER · May 18, 2020, 9:10am

Check again and look for name (in the SQL string) and hostname (which is the C variable)

github.com

pi-hole/FTL/blob/3d7c095cb10a1b692c80dd28f6051dea91d45baa/src/database/network-table.c#L453-L461


      
          				// Create new record (INSERT)
          				dbquery("INSERT INTO network "
          				        "(hwaddr,interface,firstSeen,lastQuery,numQueries,name,macVendor) "
          				        "VALUES (\'%s\',\'%s\',%lu, %ld, %u, \'%s\', \'%s\');",
          				        hwaddr, iface, now,
          				        client != NULL ? client->lastQuery : 0L,
          				        client != NULL ? client->numQueriesARP : 0u,
          				        hostname,
          				        macVendor);

When you are concerned about the mock-device to real-device update below (which is triggered only very seldom), then you should check the comment immediately below the database query command:

github.com

pi-hole/FTL/blob/3d7c095cb10a1b692c80dd28f6051dea91d45baa/src/database/network-table.c#L482-L489


      
          				dbquery("UPDATE network SET "
          				        "hwaddr = '%s', "
          				        "interface = '%s', "
          				        "macVendor = '%s' "
          				        "WHERE id = %i;",
          				        hwaddr, iface, macVendor, dbID);
          				// Host name, count and last query timestamp will be set in the next
          				// loop interation for the sake of simplicity

describing what is happening here:

github.com

pi-hole/FTL/blob/3d7c095cb10a1b692c80dd28f6051dea91d45baa/src/database/network-table.c#L508-L509


      
          			// Update hostname if available
          			rc = update_netDB_hostname(dbID, hostname);