Cool, how did you find that entry? I wonder why git log -S
doesn't pick it up.
It never was a default, as Conditional Forwarding is enabled on user request only.
Pre-5 Pi-holes wrote a different format to setupVars.conf
, but support for that has been removed since. It seems that this affected some docker setups, but the patch mentioned by ingmarstein does not seem to consider previous installations correctly.
Thanks for that link, yubiuser.
That code indeed pulls the value from
CONDITIONAL_FORWARDING_REVERSE=178.168.192.in-addr.arpa
but applies a conversion meant to deal with
REV_SERVER_TARGET=192.168.178.1
As a result, any existing CONDITIONAL_FORWARDING_REVERSE entry as correctly set by a previous version of Pi-hole will be converted to an incorrect REV_SERVER_CIDR.
This may affect all updates from Pi-hole v4 installations that have Conditional Forwarding enabled, or any younger that still have those older CONDITIONAL_FORWARDING_REVERSE entries present for whatever reasons.
EDIT: Corresponding issue is CONDITIONAL_FORWARDING_REVERSE may prevent Pi-hole from starting after update · Issue #3880 · pi-hole/pi-hole · GitHub
My setup is plain Raspbian without docker.
Ah, thanks @Bucking_Horn. Yes, this makes sense. The change introduced in pi-hole#3761
was indeed meant for docker
only. The motivation to reuse an old (and now unused) variable was incorrect as this is now causing issues for those who still have this in their config files (even when it shouldn't be there any more).
Hi Yubiser,
I don't remember to have enbaled the setting, but who knows.... Anyway, I've commented the line and FTL is back up. I'll recheck CF to see what the error could be...
Thanks!
Not that I'm aware.... I only get eventualy into the admin panel to "unlock" Fortnite servers...
Thanks everyone for the quick assistance, that was awesome!
That said, I just checked my pi, and that was into the CF section:
I can tell you that I doubt I've had entered 1.168.192.in-addr.arpa... So I guess this comes from a recent update. In any case, the solution is quite clear, CIDR notation!
We haven't used class networking subnet notation in nearly a decade.
I just remembered that there was a change recently and used the search function in github's PR section.
This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.