FTL crash

edit
not sure, but it looks like this happens when I've got the all settings page open in a browser crash also happens when web interface is not active, although less frequent.
/edit

13 crashes in log file since last update this morning

sudo pihole -v
  Pi-hole version is development-v6 v5.17.1-223-g62f9694a (Latest: v5.17.2)
  web version is development-v6 v5.19-566-g42f29b22 (Latest: v5.21)
  FTL version is development-v6 vDev-2db9776 (Latest: v5.23)
2023-12-01 11:11:12.446 [11392M] INFO: !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
2023-12-01 11:11:12.446 [11392M] INFO: ---------------------------->  FTL crashed!  <----------------------------
2023-12-01 11:11:12.446 [11392M] INFO: !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
2023-12-01 11:11:12.446 [11392M] INFO: Please report a bug at https://github.com/pi-hole/FTL/issues
2023-12-01 11:11:12.447 [11392M] INFO: and include in your report already the following details:
2023-12-01 11:11:12.447 [11392M] INFO: FTL has been running for 270 seconds
2023-12-01 11:11:12.447 [11392M] INFO: FTL branch: development-v6
2023-12-01 11:11:12.447 [11392M] INFO: FTL version: vDev-2db9776
2023-12-01 11:11:12.447 [11392M] INFO: FTL commit: 2db97761
2023-12-01 11:11:12.448 [11392M] INFO: FTL date: 2023-12-01 07:50:17 +0100
2023-12-01 11:11:12.448 [11392M] INFO: FTL user: started as pihole, ended as pihole
2023-12-01 11:11:12.448 [11392M] INFO: Compiled for linux/arm64/v8 (compiled on CI) using cc (Alpine 12.2.1_git20220924-r10) 12.2.1 20220924
2023-12-01 11:11:12.448 [11392M] INFO: Process details: MID: 11392
2023-12-01 11:11:12.448 [11392M] INFO:                  PID: 11392
2023-12-01 11:11:12.449 [11392M] INFO:                  TID: 11392
2023-12-01 11:11:12.449 [11392M] INFO:                  Name: pihole-FTL
2023-12-01 11:11:12.449 [11392M] INFO: Received signal: Segmentation fault
2023-12-01 11:11:12.449 [11392M] INFO:      at address: 0x14
2023-12-01 11:11:12.449 [11392M] INFO:      with code:  SEGV_MAPERR (Address not mapped to object)
2023-12-01 11:11:12.450 [11392M] INFO: !!! INFO: pihole-FTL has not been compiled with glibc/backtrace support, not generating one !!!
2023-12-01 11:11:12.450 [11392M] INFO: ------ Listing content of directory /dev/shm ------
2023-12-01 11:11:12.450 [11392M] INFO: File Mode User:Group      Size  Filename
2023-12-01 11:11:12.450 [11392M] INFO: rwxrwxrwx root:root       280  .
2023-12-01 11:11:12.451 [11392M] INFO: rwxr-xr-x root:root         4K  ..
2023-12-01 11:11:12.452 [11392M] INFO: rw------- pihole:pihole   544K  FTL-fifo-log
2023-12-01 11:11:12.452 [11392M] INFO: rw------- pihole:pihole     4K  FTL-per-client-regex
2023-12-01 11:11:12.453 [11392M] INFO: rw------- pihole:pihole    12K  FTL-dns-cache
2023-12-01 11:11:12.453 [11392M] INFO: rw------- pihole:pihole     8K  FTL-overTime
2023-12-01 11:11:12.454 [11392M] INFO: rw------- pihole:pihole   262K  FTL-queries
2023-12-01 11:11:12.455 [11392M] INFO: rw------- pihole:pihole    29K  FTL-upstreams
2023-12-01 11:11:12.455 [11392M] INFO: rw------- pihole:pihole    86K  FTL-clients
2023-12-01 11:11:12.456 [11392M] INFO: rw------- pihole:pihole     8K  FTL-domains
2023-12-01 11:11:12.456 [11392M] INFO: rw------- pihole:pihole    82K  FTL-strings
2023-12-01 11:11:12.457 [11392M] INFO: rw------- pihole:pihole    16  FTL-settings
2023-12-01 11:11:12.458 [11392M] INFO: rw------- pihole:pihole   292  FTL-counters
2023-12-01 11:11:12.458 [11392M] INFO: rw------- pihole:pihole    88  FTL-lock
2023-12-01 11:11:12.458 [11392M] INFO: ---------------------------------------------------
2023-12-01 11:11:12.459 [11392M] INFO: Please also include some lines from above the !!!!!!!!! header.
2023-12-01 11:11:12.459 [11392M] INFO: Thank you for helping us to improve our FTL engine!
2023-12-01 11:11:12.459 [11392M] INFO: Waiting for threads to join
2023-12-01 11:11:12.459 [11392M] INFO: Thread database (0) is idle, terminating it.
2023-12-01 11:11:12.460 [11392M] INFO: Thread housekeeper (1) is idle, terminating it.
2023-12-01 11:11:12.461 [11392M] INFO: Thread DNS client (2) is idle, terminating it.
2023-12-01 11:11:12.461 [11392M] INFO: All threads joined
2023-12-01 11:11:12.461 [11392M] ERR: Error when obtaining outer SHM lock: Resource deadlock would occur
2023-12-01 11:11:12.461 [11392M] ERR: Error when obtaining inner SHM lock: Resource deadlock would occur
2023-12-01 11:11:12.468 [11392M] INFO: Stored 0 API sessions in the database
2023-12-01 11:11:13.131 [11392M] INFO: ########## FTL terminated after 4m 30s  (code 1)! ##########

We merged quite a few large PRs yesterday, seems some conflict happened. Could you attach the debugger to FTL so we can see where the crash is happening?

https://docs.pi-hole.net/ftldns/debugging/

Attaching to process 21318
[New LWP 21319]
[New LWP 21320]
[New LWP 21321]
[New LWP 21322]
[New LWP 21323]
[New LWP 21324]
[New LWP 21325]
[New LWP 21326]
[New LWP 21327]
[New LWP 21328]
[New LWP 21329]
[New LWP 21330]
[New LWP 21331]
[New LWP 21332]
__syscall_cp_asm () at src/thread/aarch64/syscall_cp.s:28
28      src/thread/aarch64/syscall_cp.s: No such file or directory.
(gdb) c
Continuing.
[Detaching after vfork from child process 23036]
[Detaching after vfork from child process 23038]
[Detaching after vfork from child process 23766]
[Detaching after vfork from child process 23768]

Thread 1 "pihole-FTL" received signal SIGSEGV, Segmentation fault.
change_clientcount (client=0x7fb2b14260, total=<optimized out>, blocked=<optimized out>, overTimeIdx=-1, overTimeMod=0) at /app/src/datastructure.c:366
366     /app/src/datastructure.c: No such file or directory.
(gdb)

Could you please also show the result of entering backtrace?

No need to do this, actually. I think the issue is related to aliasclients and should be fixed by fix/recycle_aliasclients

Could you please verify this?

pihole checkout ftl fix/recycle_aliasclients

(as you know, in about 20-30 minutes from now)

no more crashes, please merge, so I can go back to development-v6 an continue testing

sudo pihole -v
  Pi-hole version is development-v6 v5.17.1-223-g62f9694a (Latest: v5.17.2)
  web version is development-v6 v5.19-566-g42f29b22 (Latest: v5.21)
  FTL version is fix/recycle_aliasclients vDev-f89f207 (Latest: v5.23)

It will be reviewed and merged as soon as someone can get to it.

PR has been merged into development-v6