FTL crash after update v4.3.1

Does everyone experiencing crashes use IPV6 in one way or another?
Or to put it the other way: is someone with an sole IPv4 configuration seeing crashes?

Well my backtrace looks similar to yours. I've got ipv6 configured but dhcp disabled.

I installed build 203057c... and it's working fine for me with maxdbdays set to 1 and dbinterval set to 30.
DHCP is enabled and working (no IPv6 here).

I'll set dbinterval back to 30 and report back if there's a problem.

I talked too fast... it crashed again. setting maxdbdays to 0 fixes de problem.
I don't have time to debug right now... I can do it later today if needed.

Thanks for all your testing. @bigpcjunky 's comment on the Github ticket was really helpful and I'm fairly certain we have it resolved now. Please re-checkout/update fix/neighcrash once more and test.

Some technical details: The underlying heap memory access violation occurred only when there are both, multiple addresses for the same devices in the ARP table, and only some of these addresses are already known to FTL (i.e., they sent DNS queries to the Pi-hole before).
If either all addresses of a device (or likely none) were already known to FTL because they made requests in the past, this bug doesn't show up.
This is likely because users with IPv6 are much more likely to see this bug as there is a high likelihood that an interface has at least one address that has never been used to ask Pi-hole any questions. Multiple addresses on the same interface are rather seldom in the IPv4-world.

4 Likes

i completely removed Pihole v5 and installed latest v4.

Tried the new fix:
echo "release/v5.0" | sudo tee /etc/pihole/ftlbranch
pihole checkout core release/v5.0
pihole checkout web release/v5.0
pihole checkout ftl fix/neighcrash

Looks like it keeps running!

Can confirm no crash within the last 10 minutes, normally it would occur within 30 seconds.

FTL Version vDev (fix/neighcrash, vDev-06a2cb2) is looking good for me too!

Latest fix/neighcrash is working smoothly here too
(having read the detailed info from @DL6ER, having made some changes in the network yesterday might have indeed had some impact on addresses which would explain being caught out by this despite only using IPv4 on Pi-Hole)

ok... now this build looks good.
it has been running fine for 15 minutes on my side.

please let us know when it's going to be released to the regular beta channel so I can switch back my configuration.

It has been merged to release/v5.0. You can all go back.
Thank you, again, very much for your assistance!

6 Likes