Flushing log fails with v5.9/FTL v5.14

colinabq · February 12, 2022, 9:34pm

I just updated my Pi-hole server, Now flushing the log from the command line fails with an error:

Flushing /var/log/pihole.log ...Error: in prepare, cannot modify queries because it is a view

Flushing the log from the Web Interface shows no error messages, but also fails to actually flush the log. This just started today (02/12/2022), after updating to ...
Pi-hole v5.9 FTL v5.14 Web Interface v5.11

System summary:
Ubuntu server 20.04.03 LTS
lighttpd/1.4.55
edit: PHP version 7.4.3

Any tips on this? Thanks

yubiuser · February 12, 2022, 10:27pm

It's a bug. We fix it.

colinabq · February 12, 2022, 10:39pm

Thanks, response much appreciated!

yubiuser · February 12, 2022, 10:39pm

github.com/pi-hole/pi-hole

Fix log flush with new query database schema

pi-hole:development ← pi-hole:fix/flush

opened 10:39PM - 12 Feb 22 UTC

yubiuser

+1 -1

- [x] I have read and understood the [contributors guide](https://github.com/pi-…hole/pi-hole/blob/master/CONTRIBUTING.md), as well as this entire template. - [x] I have made only one major change in my proposed changes. - [x] I have commented my proposed changes within the code. - [x] I have tested my proposed changes, and have included unit tests where possible. - [x] I am willing to help maintain this change if there are issues with it later. - [x] I give this submission freely and claim no ownership. - [x] It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1) - [x] I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html)) Please make sure you [Sign Off](https://docs.pi-hole.net/guides/github/how-to-signoff/) all commits. Pi-hole enforces the [DCO](https://docs.pi-hole.net/guides/github/contributing/). --- **What does this PR aim to accomplish?:** Fixes a bug reported on discourse: https://discourse.pi-hole.net/t/flushing-log-fails-with-v5-9-ftl-v5-14/53532/1 With https://github.com/pi-hole/FTL/pull/1255 the table `queries` was converted to a view and the actual data is now in `query_storage`. We forgot to adjust the `flush_log` function accordingly. ``` rockpi@rockpi-4b:~$ pihole -f [sudo] password for rockpi: [i] Flushing /var/log/pihole.log ...Error: in prepare, cannot modify queries because it is a view (1) [✓] Restarting DNS server [✓] Flushed /var/log/pihole.log [✓] Deleted queries from database ... Current Pi-hole version is fix/flush v5.8.1-50-gf4286a4d Current AdminLTE version is devel v5.10.1-84-g10984d52 Current FTL version is development vDev-3a5c0ac rockpi@rockpi-4b:~$ pihole -f [✓] Restarting DNS server [✓] Flushed /var/log/pihole.log [✓] Deleted 16806 queries from database ```

Ty5 · February 13, 2022, 6:09am

Having somewhat of the same problem after updating. Both web interface and command-line fail.

"Flushing /var/log/pihole.log ...Error: in prepare, cannot modify queries because it is a view (1)"

Any thoughts to why?

Thanks

yubiuser · February 13, 2022, 8:29am

We fixed the bug, the patch will be part of the next Pi-hole release.

neil62 · February 13, 2022, 9:39pm

So, how are users now able to flush the logs without having to wiat for the next release?

yubiuser · February 13, 2022, 11:55pm

You can run a custom branch:

pihole checkout core fix/flush

To get back on track (and before the next release) you need to perform

pihole checkout master

CesarCamacho · February 20, 2022, 12:37pm

after update i can't flush dns

system · March 6, 2022, 11:56pm

This topic was automatically closed 21 days after the last reply. New replies are no longer allowed.