Encountered non-critical SQL warnings

General Beta 5.0
127

This is a list that will get 100% Quality, note the domains that are whitelisted from it. Do you know that list has approved all these domains for access?

128

I, for once, did read this as an acknowledgement of DL6ER's latest additions to blacklist import.

What's wrong with that?

Or did I misinterpret something here?

1 Like
130

This is my stance. There is no rating, no percentage, no implied approval or disapproval. Just the bare facts of how many domains were accepted. Just like we did before with listing the number of domains imported.

2 Likes
131

The full quote is below. Yesterday I made the statement "Crap in Crap Out". The statement below was a nice little dig at me. Everyone around here thinks I'm the angry, grump guy that is out to destroy Pi-hole and ride off in to the sunset.

138

it woks perfectly, i can see outputs on broken lists, and which need to be removed.

139

I agree on the quality being unclever. Showing a net number of what was not imported is an obvious quantity for the "HOSTS likeness" of the list. Quality is misleading here.

Maybe like this?

  [✓] Status: Retrieval successful
  [i] Imported 51223 of 51233 lines, 10 lines invalid
      Sample of invalid domains:
      - банрек.рус
      - укроп-петрушка-огурцы.рф
      - хельга.рф
      - эхх.рф
      - mxtads.com:8040

I'm ready to change it to whatever we agree on, however, I'd obviously prefer to not change this multiple times...

2 Likes
140

Does that number also include empty lines or comments?
If that's the case, I'd prefer Processed instead of Imported.
Otherwise :+1:

141

[i] Imported 51223 of 51233 eligible lines, 10 lines invalid

or

[i] Imported 51223 of 51233 importable lines, 10 lines invalid

This would make it clear that comments and empty lines are never considered for import.

142

I'm good with this. Simple and concise. It should be obvious that empty lines and comments are not imported.

1 Like
143

No, empty lines and comments are stripped before. This is the number of what remains and what would be added to the database.

1 Like
144

Latest update gives following outpu

i] Target: http://www.malwaredomainlist.com/hostslist/hosts.txt
  [✓] Status: No changes detected
  [i] Received 1104 domains

  [i] Target: https://easylist.to/easylistgermany/easylistgermany.txt
  [✓] Status: Retrieval successful
  [i] Received 945 domains, 943 domains invalid!
      Sample of invalid domains:
      - 1.1]
      - easylist.germany@gmail.com
      - ||2mdn.net^$object,third-party,domain=anleger-fernsehen.de|blick.ch|fitforfun.de|focus.de|giga.de|golem.de|helpster.de|myspass.de|netzwelt.de|stol.it|sueddeutsche.de|tvtoday.de
      - ||4rm.de^$third-party
      - ||85.114.133.62^$third-party

  [i] Target: http://pgl.yoyo.org/adservers/serverlist.php?hostformat=hosts&showintro=0&mimetype=plaintext
  [✓] Status: Retrieval successful
  [i] Received 3292 domains
145

This has been merged. Please switch back to the beta branch to continue receiving updates

pihole checkout core release/v5.0
2 Likes