Enabling SSL and mod_openssl

borpin · January 26, 2023, 7:35am

I have recently migrated my Pi-hole install to a new Ubuntu 20.04 PVE LXC. In setting up the SSL certificates from CloudFlare via Certbot DNS, I discovered that the mod_openssl server module appeared to not be installed or enabled.

I have now installed lighttpd-mod-openssl from apt and added it to the server.modules but this can only be done in /etc/lighttpd/lighttpd.conf it seems (I did try in external.conf but that didn't work).

Thus after every update, I will need to re-add the server.module.

Is there another workaround, or could it be enabled as standard?

PromoFaux · January 26, 2023, 8:01am

remove:

###############################################################################
#     FILE AUTOMATICALLY OVERWRITTEN BY PI-HOLE INSTALL/UPDATE PROCEDURE.     #
# ANY CHANGES MADE TO THIS FILE AFTER INSTALL WILL BE LOST ON THE NEXT UPDATE #
#                                                                             #
#              CHANGES SHOULD BE MADE IN A SEPARATE CONFIG FILE:              #
#                         /etc/lighttpd/external.conf                         #
###############################################################################

From the top of the file which will stop it
being overwritten on the next update

github.com

pi-hole/pi-hole/blob/262ffe458b17fe9032b8a3ac9e19660c2f07410f/automated install/basic-install.sh#L1412-L1420


      
          if grep -q -F "FILE AUTOMATICALLY OVERWRITTEN BY PI-HOLE" "${lighttpdConfig}"; then
              # Attempt to preserve backwards compatibility with older versions
              install -D -m 644 -T ${PI_HOLE_LOCAL_REPO}/advanced/${LIGHTTPD_CFG} "${lighttpdConfig}"
              # Make the directories if they do not exist and set the owners
              mkdir -p /var/cache/lighttpd/compress
              chown ${LIGHTTPD_USER}:${LIGHTTPD_GROUP} /var/cache/lighttpd/compress
              mkdir -p /var/cache/lighttpd/uploads
              chown ${LIGHTTPD_USER}:${LIGHTTPD_GROUP} /var/cache/lighttpd/uploads
          fi

We are taking steps that prevent us from clobbering the default lighttpd config on newer installs - as it's just bad practice. But that also means you can swap out lighttpd config on an existing install and things should still work because we have migrated the relevant stuff for us into conf-available/15-pihole-admin.conf

borpin · January 26, 2023, 8:03am

Could the header be amended to say that as well for now?

Many thanks.

PromoFaux · January 26, 2023, 12:49pm

This is a very good idea. I will add this to my todo list

system · February 2, 2023, 12:49pm

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.