Difference in update entries "No Changes detected" and "List stayed unchanged"

yubiuser · June 6, 2022, 4:40pm

Exactly.

Status: No changes detected is based on the http header response

gravity.sh

2735481da


      
          case "${httpCode}" in
            "200") echo -e "${OVER}  ${TICK} ${str} Retrieval successful"; success=true;;
            "304") echo -e "${OVER}  ${TICK} ${str} No changes detected"; success=true;;
            "000") echo -e "${OVER}  ${CROSS} ${str} Connection Refused";;
            "403") echo -e "${OVER}  ${CROSS} ${str} Forbidden";;
            "404") echo -e "${OVER}  ${CROSS} ${str} Not found";;
            "408") echo -e "${OVER}  ${CROSS} ${str} Time-out";;
            "451") echo -e "${OVER}  ${CROSS} ${str} Unavailable For Legal Reasons";;
            "500") echo -e "${OVER}  ${CROSS} ${str} Internal Server Error";;
            "504") echo -e "${OVER}  ${CROSS} ${str} Connection Timed Out (Gateway)";;
            "521") echo -e "${OVER}  ${CROSS} ${str} Web Server Is Down (Cloudflare)";;
            "522") echo -e "${OVER}  ${CROSS} ${str} Connection Timed Out (Cloudflare)";;
            *    ) echo -e "${OVER}  ${CROSS} ${str} ${url} (${httpCode})";;
          esac;;

And List stayed unchanged really compares the the checksum of the downloaded files after http return code was 200.

github.com/pi-hole/pi-hole

gravity.sh

2735481da


      
          compareLists() {
            local adlistID="${1}" target="${2}"
          
            # Verify checksum when an older checksum exists
            if [[ -s "${target}.sha1" ]]; then
              if ! sha1sum --check --status --strict "${target}.sha1"; then
                # The list changed upstream, we need to update the checksum
                sha1sum "${target}" > "${target}.sha1"
                echo "  ${INFO} List has been updated"
                database_adlist_status "${adlistID}" "1"
                database_adlist_updated "${adlistID}"
              else
                echo "  ${INFO} List stayed unchanged"
                database_adlist_status "${adlistID}" "2"
              fi
            else
              # No checksum available, create one for comparing on the next run
              sha1sum "${target}" > "${target}.sha1"
              # We assume here it was changed upstream
              database_adlist_status "${adlistID}" "1"

This file has been truncated. show original

See the missing last-modified for github

chrko@ThinkPad-X230:~$ curl -L -I https://raw.githubusercontent.com/jerryn70/GoodbyeAds/master/Hosts/GoodbyeAds.txt -o -
HTTP/2 200 
cache-control: max-age=300
content-security-policy: default-src 'none'; style-src 'unsafe-inline'; sandbox
content-type: text/plain; charset=utf-8
etag: "2fb1b9db6f93375408cb26ca6988eadb8a0bdd7e3b426e12a300be681466430d"
strict-transport-security: max-age=31536000
x-content-type-options: nosniff
x-frame-options: deny
x-xss-protection: 1; mode=block
x-github-request-id: C21C:4053:50A535:560C50:629E2C10
accept-ranges: bytes
date: Mon, 06 Jun 2022 16:39:09 GMT
via: 1.1 varnish
x-served-by: cache-hhn4031-HHN
x-cache: MISS
x-cache-hits: 0
x-timer: S1654533550.685185,VS0,VE83
vary: Authorization,Accept-Encoding,Origin
access-control-allow-origin: *
x-fastly-request-id: a1ef16c1df1e82a8c0ae4233de89d98c5bc60290
expires: Mon, 06 Jun 2022 16:44:09 GMT
source-age: 0
content-length: 5943985

chrko@ThinkPad-X230:~$ curl -L -I https://block.energized.pro/extensions/regional/formats/hosts -o -
HTTP/2 200 
date: Mon, 06 Jun 2022 16:39:37 GMT
content-type: application/octet-stream
content-length: 981172
last-modified: Mon, 06 Jun 2022 14:15:29 GMT
etag: "629e0c01-ef8b4"
accept-ranges: bytes
cf-cache-status: DYNAMIC
expect-ct: max-age=604800, report-uri="https://report-uri.cloudflare.com/cdn-cgi/beacon/expect-ct"
report-to: {"endpoints":[{"url":"https:\/\/a.nel.cloudflare.com\/report\/v3?s=Q4FO4qJAobrBKPN8n98N1pLMqr0R5VFkKrqysBuj%2B1u0Kvk085LXgTSvtQKD3WRE%2FPZrG8jJeLWN0605vrxvn1UwmTYigVniveB%2BaRr6oeAsr293kMAF82ILRsJEEC8iOZTmgnig%2F5OCpUecWIeD4Frm"}],"group":"cf-nel","max_age":604800}
nel: {"success_fraction":0,"report_to":"cf-nel","max_age":604800}
server: cloudflare
cf-ray: 717295cd0b8a6d73-MUC
alt-svc: h3=":443"; ma=86400, h3-29=":443"; ma=86400