Convinced 
Just tested the dark mode and it works great, thank you for adding this feature.
Personally, I like the idea of reviewed style sheets. Prevention of malicious activities and reduced risk of something "weird" occurring causing additional troubleshoot.
In addition, I assume that if one did not want to have their "theme" reviewed they can still always modified their local install.
That's for sure. Pi-hole is open in all regards, there are no proprietary blobs involved. If you want to change something and don't send this back to the main project, you can very well do this. However, you will then obviously have to deal with possible conflicts arising due to changes in the main project (which is why submitting is better as it puts the maintenance burden onto us).
Since this is not going to be implemented in 5.0 should I return to the regular beta branches or will the two branches for the dark theme periodically be updated with the changes that are being merged into Release/V5.0?
The dark theme is not currently planned for 5.0. If you want to continue using it, you will need the two custom branches.
Original, unchanged Pi-hole 5.0 (branch release/v5.0) in Chrome 81 with enforced dark mode
(chrome://flags/#enable-force-dark)
I know to keep using it I will have to stay on the custom branches but will choose to give it up if there is not plans to update the branches with the changes that go into V5.0. Would rather have updated code and lose dark mode than old code with dark mode.
The v5.0 code is done. At least, we hope so. The release is basically finished, we just wait for enough developers to be around at the same time for pushing the RELEASE NOW button. I don't think there will be many more updates to follow. Afterwards, this PR will probably be merged rather soon into development where we will continue our work.
Thanks, I don't run Chrome but this seems similar, with obviously some obstacles such as generally white bright colors and white borders around the charts. Furthermore, the host name in the upper right looks odd. Still interesting to see what they do in converting webpages.
1 Like
Amazing 
hello... small problem here..
pi@pihole01:~ $ pihole -v
Pi-hole version is new/dark v4.3.5-492-g71bc985 (Latest: v5.0)
AdminLTE version is new/dark v5.0-17-gf028aec (Latest: v5.0)
FTL version is release/v5.0 vDev-c499c17 (Latest: v5.0)
pi@pihole01:~ $ pihole -up
[i] Checking for updates...
[i] Pi-hole Core: up to date
[i] Web Interface: update available
[i] FTL: up to date
[i] Warning: You are using FTL from a custom branch (release/v5.0) and might be missing future releases.
[i] Pi-hole Web Admin files out of date, updating local repo.
[✓] Check for existing repository in /var/www/html/admin
[i] Update repo in /var/www/html/admin...
: Could not update local repository. Contact support.
Try
root@pihole02:/var/www/html/admin# sudo git reset --hard HEAD^^
HEAD is now at 99048738 Improve charts overlay in dark mode
root@pihole02:/var/www/html/admin# sudo git pull
Auto-merging style/themes/default-light.css
CONFLICT (add/add): Merge conflict in style/themes/default-light.css
Auto-merging style/themes/default-dark.css
CONFLICT (add/add): Merge conflict in style/themes/default-dark.css
Auto-merging style/pi-hole.css
CONFLICT (content): Merge conflict in style/pi-hole.css
Auto-merging settings.php
CONFLICT (content): Merge conflict in settings.php
Auto-merging scripts/pi-hole/php/savesettings.php
Auto-merging scripts/pi-hole/php/header.php
CONFLICT (content): Merge conflict in scripts/pi-hole/php/header.php
Auto-merging scripts/pi-hole/js/queries.js
CONFLICT (content): Merge conflict in scripts/pi-hole/js/queries.js
Auto-merging scripts/pi-hole/js/network.js
CONFLICT (content): Merge conflict in scripts/pi-hole/js/network.js
Auto-merging scripts/pi-hole/js/index.js
CONFLICT (content): Merge conflict in scripts/pi-hole/js/index.js
Auto-merging scripts/pi-hole/js/footer.js
CONFLICT (content): Merge conflict in scripts/pi-hole/js/footer.js
Auto-merging scripts/pi-hole/js/db_lists.js
CONFLICT (content): Merge conflict in scripts/pi-hole/js/db_lists.js
Auto-merging queryads.php
CONFLICT (content): Merge conflict in queryads.php
Auto-merging network.php
CONFLICT (content): Merge conflict in network.php
Removing img/favicons/mstile-150x150.png
Auto-merging groups-domains.php
Auto-merging debug.php
Auto-merging db_graph.php
CONFLICT (content): Merge conflict in db_graph.php
Automatic merge failed; fix conflicts and then commit the result.
Try
sudo git reset --hard master
sudo git pull
1 Like
how can i change my web view to dark mode in 5.0??
It's not yet a complete feature, and is being actively developed. Hopefully we should have it ready for 5.1, but no ETA on that I'm afraid
on my first pihole it works but on the second one it doesn't
root@pihole02:/etc/.pihole# pihole -v
Pi-hole version is new/dark v4.4 (Latest: v5.0)
AdminLTE version is new/dark v4.3.3 (Latest: v5.0)
FTL version is release/v5.0 vDev-c499c17 (Latest: v5.0)
root@pihole02:/etc/.pihole# pihole -up
[i] Checking for updates...
[i] Pi-hole Core: update available
[i] Web Interface: update available
[i] FTL: up to date
[i] Warning: You are using FTL from a custom branch (release/v5.0) and might be missing future releases.
[i] Pi-hole core files out of date, updating local repo.
[✓] Check for existing repository in /etc/.pihole
[i] Update repo in /etc/.pihole...
: Could not update local repository. Contact support.
root@pihole02:/etc/.pihole# cd /etc/.pihole
root@pihole02:/etc/.pihole# sudo git reset --hard master
HEAD is now at 9e490775 Merge pull request #3166 from pi-hole/release/v4.4
root@pihole02:/etc/.pihole# sudo git pull
Your configuration specifies to merge with the ref 'refs/heads/new/dark'
from the remote, but no such ref was fetched.
root@pihole02:/etc/.pihole# pihole -up
[i] Checking for updates...
[i] Pi-hole Core: update available
[i] Web Interface: update available
[i] FTL: up to date
[i] Warning: You are using FTL from a custom branch (release/v5.0) and might be missing future releases.
[i] Pi-hole core files out of date, updating local repo.
[✓] Check for existing repository in /etc/.pihole
[i] Update repo in /etc/.pihole...
: Could not update local repository. Contact support.
and no dark mode
The dark mode has been merged into development now. Try a pihole checkout dev
Woah, the next release will be a bombastic fantastic one. And I'm also watching github, even more fancy stuff has already reached the v5.1 code.
Amazing work all around.