Binog
March 26, 2018, 8:52am
1
Hey there,
Have theses errors: I had over 700k blacklists loaded 2 weeks ago.
No merely 199k. haven't changed a thing.
Guess there is an other problem: while pihole -g
[i] Target: local (adblock.blacklist)
[✗] Status: /etc/adblock/adblock.blacklist 000
[✗] List download failed: no cached list available
The status url links to an unknown place. it should lead to /etc/pihole/blacklist.txt, doesn't it?
Later, it summarizes correctly [i] Number of blacklisted domains: 46
at the end it says:
[i] Consolidating blocklists.../opt/pihole/gravity.sh: count 385: warning: command substitution: ignored null byte in input
Anyone can help?
My debug token is: 5aaytz5teh
This needs to be a URL not just a filepath. You can try file:///etc/adblock/adblock.blacklist
but I don't know for sure if that is supported--checking with the team on that.
Otherwise, people usually upload their lists to GitHub and pull them down that way--easier to maintain that was usually.
Binog
March 26, 2018, 11:34am
3
Thx for replying. but where to set that URL?
I do not have an entry im my list,. as far as I can see from the Webpage.
Web interface > Settings > Block Lists
It doesn't look like local lists appear in the Web GUI, which may be a minor bug (@DL6ERor @Mcat12 may be interested in looking into), but you can verify it's there by running pihole -g
. You'll see
[i] Target: local (adblock.blacklist)
[✓] Status: Retrieval successful
Binog
March 29, 2018, 1:03pm
5
1st:
running "pihole -g" - I do see this. but then again. There is no /etc/adblock/ directory !
"
[i] Target: local (adblock.blacklist)
[✗] Status: /etc/adblock/adblock.blacklist 000
[✗] List download failed: no cached list available
"
I nowhere wrote that URL. So why does pi-hole gives that entry? there must be a faulty line in any script!?!
2nd:
[i] Consolidating blocklists…/opt/pihole/gravity.sh: count 385: warning: command substitution: ignored null byte in input
should I re-install pihole? what can I do?
Send another debug token.
Binog
March 30, 2018, 12:07pm
7
Ok, got one culprit. My adlist did contain /etc/adlist.. commented it out.
Still shows last error:
Your debug token is: tj9xs5jndn
Can you PM me? I'd like to get a copy of all your lists so I can replicate that error message. I can't seem to do it on my test systems.
This is actually already an open issue on GitHub:
opened 01:10PM - 07 Mar 18 UTC
closed 12:15AM - 13 May 21 UTC
Bug: Confirmed
triage: Issue
**In raising this issue, I confirm the following:** `{please fill the checkboxes… , e.g: [X]}`
- [x] I have read and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md).
- [x] The issue I am reporting can be *replicated*.
- [x] The issue I am reporting isn't a duplicate (see [FAQs](https://github.com/pi-hole/pi-hole/wiki/FAQs), [closed issues](https://github.com/pi-hole/pi-hole/issues?utf8=%E2%9C%93&q=is%3Aissue%20is%3Aclosed%20), and [open issues](https://github.com/pi-hole/pi-hole/issues)).
**How familiar are you with the the source code relevant to this issue?:**
`{1}`
---
**Expected behaviour:**
`{running update procedure. no errors,. full walk-through}`
**Actual behaviour:**
`{running upgrade list. getting at the end following error:
Consolidating blocklists.../opt/pihole/gravity.sh: 385: Warnung: command substitution: ignored null byte in input
}`
**Steps to reproduce:**
`{Detailed steps of how we can reproduce this}`
**Debug token provided by [*** [ DIAGNOSING ]: contents of /var/log/lighttpd
-rw-r--r-- 1 www-data www-data 2124 Mär 7 14:05 /var/log/lighttpd/error.log
2018-03-04 06:25:27: (server.c.1534) logfiles cycled UID = 0 PID = 12036
2018-03-04 09:07:35: (mod_fastcgi.c.2543) FastCGI-stderr: PHP Notice: Undefined offset: 23 in /var/www/html/pihole/index.php on line 293
2018-03-04 09:49:02: (mod_fastcgi.c.2543) FastCGI-stderr: PHP Notice: Undefined offset: 23 in /var/www/html/pihole/index.php on line 293
2018-03-04 14:38:19: (mod_fastcgi.c.2543) FastCGI-stderr: PHP Notice: Undefined offset: 23 in /var/www/html/pihole/index.php on line 293
2018-03-04 15:06:49: (mod_fastcgi.c.2543) FastCGI-stderr: PHP Notice: Undefined offset: 23 in /var/www/html/pihole/index.php on line 293
2018-03-04 20:07:19: (mod_fastcgi.c.2543) FastCGI-stderr: PHP Warning: file(http://127.0.0.1/admin/scripts/pi-hole/php/queryads.php?domain=ocsp.apple.com&bp): failed to open stream: HTTP request failed! in /var/www/html/pihole/index.php on line 136
2018-03-04 20:07:19: (mod_fastcgi.c.2543) FastCGI-stderr: PHP Warning: array_filter() expects parameter 1 to be array, string given in /var/www/html/pihole/index.php on line 137
2018-03-04 20:07:19: (mod_fastcgi.c.2543) FastCGI-stderr: PHP Warning: array_values() expects parameter 1 to be array, null given in /var/www/html/pihole/index.php on line 137
2018-03-06 13:11:09: (mod_fastcgi.c.2543) FastCGI-stderr: PHP Warning: file(http://127.0.0.1/admin/scripts/pi-hole/php/queryads.php?domain=ocsp.apple.com&bp): failed to open stream: HTTP request failed! in /var/www/html/pihole/index.php on line 136
2018-03-06 13:11:09: (mod_fastcgi.c.2543) FastCGI-stderr: PHP Warning: array_filter() expects parameter 1 to be array, string given in /var/www/html/pihole/index.php on line 137
2018-03-06 13:11:09: (mod_fastcgi.c.2543) FastCGI-stderr: PHP Warning: array_values() expects parameter 1 to be array, null given in /var/www/html/pihole/index.php on line 137
2018-03-07 14:05:32: (mod_fastcgi.c.2543) FastCGI-stderr: PHP Notice: Undefined offset: 85 in /var/www/html/pihole/index.php on line 293
2018-03-07 14:05:32: (mod_fastcgi.c.2543) FastCGI-stderr: PHP Notice: Undefined offset: 85 in /var/www/html/pihole/index.php on line 293):**
`{Alphanumeric token}`
**Troubleshooting undertaken, and/or other relevant information:**
`{Steps of what you have done to fix this}`
pi-hole:development
← pi-hole:fix/nullbyte
opened 07:12PM - 31 Mar 18 UTC
**By submitting this pull request, I confirm the following:**
*please fill any… appropriate checkboxes, e.g: [X]*
- [x] I have read and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md), as well as this entire template.
- [x] I have made only one major change in my proposed changes.
- [x] I have commented my proposed changes within the code.
- [x] I have tested my proposed changes, and have included unit tests where possible.
- [x] I am willing to help maintain this change if there are issues with it later.
- [x] I give this submission freely and claim no ownership.
- [x] It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1)
- [x] I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html))
Please make sure you [Sign Off](https://github.com/pi-hole/pi-hole/wiki/How-to-signoff-your-commits.) all commits. Pi-hole enforces the [DCO](https://github.com/pi-hole/pi-hole/wiki/Contributing-to-the-project).
---
**What does this PR aim to accomplish?:**
Remove this error some users see:
```
/opt/pihole/gravity.sh: 385: Warning: command substitution: ignored null byte in input
```
**How does this PR accomplish the above?:**
Removed null bytes with `tr -d` as mentioned [here](https://stackoverflow.com/questions/46163678/get-rid-of-warning-command-substitution-ignored-null-byte-in-input?utm_medium=organic&utm_source=google_rich_qa&utm_campaign=google_rich_qa).
**What documentation changes (if any) are needed to support this PR?:**
None
---
* You must follow the template instructions. Failure to do so will result in your pull request being closed.
* Please respect that Pi-hole is developed by volunteers, who can only reply in their spare time.
@Binog can you run
pihole checkout core fix/nullbyte
pihole -g
and see if the error is gone?
Binog
March 31, 2018, 7:30pm
11
well, sadly, no,..
[i] Consolidating blocklists.../opt/pihole/gravity.sh: count 385: warning: command substitution: ignored null byte in input
OK, can you run the commands again? I tried something else.
Binog
April 1, 2018, 7:06am
13
Seems as if the fetching did not work. I get a red x there.
Thus,.I get the same error while running pihole -g.
OK, can you send me your lists and I'll try to duplicate from scratch:
cat /etc/pihole/adlists.list | pihole tricorder
Can you also tell me the output of locale
?
system
Closed
May 4, 2018, 8:53am
15
This topic was automatically closed 21 days after the last reply. New replies are no longer allowed.