lw1
January 26, 2020, 11:22am
1
Problem with Beta 5.0:
If I try to assign a group to the last item in the list of configured clients in client group management, the dropdown opens inside the box and a scrollbar is added.
Update: same issue in all tables of the group management section
Debug Token:
n/a
DL6ER
January 27, 2020, 12:12pm
2
This is somewhat expected as the dropdown lives inside the table itself. Does this prevent you from being able to reach the last option or is that possible after scrolling down?
lw1
January 27, 2020, 8:09pm
3
I can select the last option.
DL6ER
January 27, 2020, 9:29pm
4
Okay, so it is more a cosmetic issue. Someone who actually learned how to code Javascript (in contrast to me!) might be able to comment on this and how to achieve that the select box is not tied into the table container.
cmgeek
February 16, 2020, 7:51am
5
I also noticed this - it's a cosmetic issue, after scrolling down I can assign user to the group.
5.0 runs on a Pi1 without any issues.
DL6ER
February 16, 2020, 8:08am
6
It appears I'm maybe not as bad as I thought when it comes to web coding. Please try whether
pihole checkout web fix/group_assignment_allow_overflow
fixes this.
It seems to work for me (Firefox 73.0 on Ubuntu 19.10):
edit Connected pull request:
pi-hole:release/v5.0
← pi-hole:fix/group_assignment_allow_overflow
opened 08:15AM - 16 Feb 20 UTC
**By submitting this pull request, I confirm the following:**
- [X] I have r… ead and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md), as well as this entire template.
- [X] I have made only one major change in my proposed changes.
- [X] I have commented my proposed changes within the code.
- [X] I have tested my proposed changes, and have included unit tests where possible.
- [X] I am willing to help maintain this change if there are issues with it later.
- [X] I give this submission freely and claim no ownership.
- [X] It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1)
- [X] I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html))
---
**What does this PR aim to accomplish?:**
Prevent parts of group assignment to be hidden inside the table container. This has been reported on Discourse.
**How does this PR accomplish the above?:**
Enable visibility of overflow in table-responsive to ensure the group assignment dropdown doesn't get hidden when opened.
**What documentation changes (if any) are needed to support this PR?:**
None
1 Like
cmgeek
February 16, 2020, 10:15am
7
Sweet! tx+
Firefox 73.0 (64-bit) / xubuntu 18.04 / Xfce 4.12.3
lw1
February 16, 2020, 10:31am
8
It works, but there is a problem when there are many groups and you try to change the last entry on the page. The dropdown gets longer than the page size.
Maybe the dropdowns at the bottom should open to the top?
DL6ER
February 16, 2020, 10:35am
9
One problem solved, another one added... Not sure how to achieve this best. It is not only the last one, assume you have 25 groups. Maybe they wouldn't fit at all to the page. Maybe the scrolling bar "option" (so what was there before my proposed fix) is still the better one overall?...
lw1
February 16, 2020, 10:40am
10
How about something like this? Bootstrap Snippet Scrollable Dropdown Menu using HTML CSS Bootstrap
You don't have to scroll the whole page and users with many entries can select everything.
I have found a solution (which appears to be basically the same solution ) will push to that branch
@lw1 , should be fixed for you now...
lw1
February 16, 2020, 1:43pm
13
If you click the last item on the page there is a scrollbar, but the dropdown is still too long for the page.
normal:
last item:
Ah, I missed a step.... Moment, please!
Hmmm, not able to reproduce that..
What browser are you using?
edit: If I make the browser window smaller, then I can reproduce it.
lw1
February 16, 2020, 1:52pm
16
I'm using Firefox 73.0 on Windows 10.
Edit: the size of my browser window is 2735x1016px (according to https://www.whatsmybrowser.org/ )
Edit2: same error using MS Edge 80.0.361.54
Just pushed another change, try again please!
lw1
February 16, 2020, 3:55pm
18
The scrollbar is now gone and the menu is still too long.
Can you try refreshing your browser cache, please? It is definitely working for me on this end
lw1
February 16, 2020, 4:09pm
20
It works in the list of configured clients, but not for domains and adlists. I was testing on the adlist-page.