Please follow the below template, it will help us to help you!
Expected Behaviour:
Click on "Audit" button adds domain to audit list in V5.1
Actual Behaviour:
Domain not added, but Lighttpd error thrown:
2020-07-27 08:06:55: (mod_fastcgi.c.2543) FastCGI-stderr: PHP Notice: Undefined variable: type in /var/www/html/admin/scripts/pi-hole/php/groups.php on line 513
Debug Token:
https://tricorder.pi-hole.net/zt5cygjf4u
Known issue, fix in pipline
opened 06:11PM - 22 Jun 20 UTC
closed 06:56AM - 10 Aug 20 UTC
Bug
Bugfix in progress
**In raising this issue, I confirm the following:**
- [x] I have read and und… erstood the [contributors guide](https://github.com/pi-hole/AdminLTE/blob/master/CONTRIBUTING.md).
- [x] The issue I am reporting can be *replicated*.
- [x] The issue I am reporting isn't a duplicate (see [FAQs](https://github.com/pi-hole/pi-hole/wiki/FAQs), [closed issues](https://github.com/pi-hole/AdminLTE/issues?utf8=%E2%9C%93&q=is%3Aissue%20is%3Aclosed%20), and [open issues](https://github.com/pi-hole/AdminLTE/issues)).
**How familiar are you with the the source code relevant to this issue?:**
1
---
**Expected behaviour:**
Click on "Audit" button on audit log should add the domain to the audit log (`domain_audit` table)
**Actual behaviour:**
Click on "Audit" button on audit log does not add the domain to the audit log (`domain_audit` table) and produces error in `var/log/lighttpd/error.log`
```
2020-06-22 19:54:14: (mod_fastcgi.c.421) FastCGI-stderr: PHP Notice: Undefined variable: type in /var/www/html/admin/scripts/pi-hole/php/groups.php on line 513
2020-06-22 19:54:14: (mod_fastcgi.c.421) FastCGI-stderr: PHP Notice: Undefined variable: type in /var/www/html/admin/scripts/pi-hole/php/groups.php on line 513
2020-06-22 19:54:15: (mod_fastcgi.c.421) FastCGI-stderr: PHP Notice: Undefined variable: type in /var/www/html/admin/scripts/pi-hole/php/groups.php on line 476
2020-06-22 19:54:15: (mod_fastcgi.c.421) FastCGI-stderr: PHP Notice: Undefined index: type in /var/www/html/admin/scripts/pi-hole/php/groups.php on line 507
2020-06-22 19:54:15: (mod_fastcgi.c.421) FastCGI-stderr: PHP Notice: Undefined variable: type in /var/www/html/admin/scripts/pi-hole/php/groups.php on line 513
2020-06-22 19:54:15: (mod_fastcgi.c.421) FastCGI-stderr: PHP Notice: Undefined variable: type in /var/www/html/admin/scripts/pi-hole/php/groups.php on line 513
2020-06-22 19:54:16: (mod_fastcgi.c.421) FastCGI-stderr: PHP Notice: Undefined variable: type in /var/www/html/admin/scripts/pi-hole/php/groups.php on line 476
2020-06-22 19:54:16: (mod_fastcgi.c.421) FastCGI-stderr: PHP Notice: Undefined index: type in /var/www/html/admin/scripts/pi-hole/php/groups.php on line 507
```
**Steps to reproduce:**
```
nanopi@nanopi:~$ pihole -v
Pi-hole version is development v5.0-105-g3aaf9d8 (Latest: v5.0)
AdminLTE version is devel v5.0-395-g536ecd69 (Latest: v5.0)
FTL version is development vDev-336d72c (Latest: v5.0)
```
Click on "Audit" in the audit log page.
**Troubleshooting undertaken, and/or other relevant information:**
There was a similar issue before that was fixed before v5.0 was released. Might be a regression.
https://github.com/pi-hole/AdminLTE/issues/1139
pi-hole:release/v5.1.1
← pi-hole:fix/audit_log
opened 08:07PM - 20 Jul 20 UTC
**By submitting this pull request, I confirm the following:**
- [X] I have r… ead and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md), as well as this entire template.
- [X] I have made only one major change in my proposed changes.
- [X] I have commented my proposed changes within the code.
- [X] I have tested my proposed changes, and have included unit tests where possible.
- [X] I am willing to help maintain this change if there are issues with it later.
- [X] I give this submission freely and claim no ownership.
- [X] It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1)
- [X] I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html))
---
**What does this PR aim to accomplish?:**
Fix audit log feature #1470 https://github.com/pi-hole/pi-hole/issues/3552
**How does this PR accomplish the above?:**
Add missing action to add domains to the audit log table.
**What documentation changes (if any) are needed to support this PR?:**
None
system
Closed
August 17, 2020, 7:35am
3
This topic was automatically closed 21 days after the last reply. New replies are no longer allowed.