Automatically delete current DCHP lease when static assignment is added for the same device

yubiuser · July 31, 2022, 11:56am

Ported from

DHCP lease changes have no visual indication of whether they've been applied/saved or not.

opened 08:44AM - 30 Jul 22 UTC

### Versions ``` durr@lxchole:~$ pihole -v Current Pi-hole version is v5.…11.4 Current AdminLTE version is v5.13 Current FTL version is v5.16.1 ``` ### Platform - OS and version: Ubuntu 20.04 LTS - Platform: LXC ### Expected behavior When you add a static DHCP lease, and then reboot the device that the lease specifies the IP for, I'd expect the device to use the newly configured address. ### Actual behavior / bug Adding a new DHCP static lease has lower priority then any active dynamic leases, and the process of adding a static lease does not clear any dynamic lease for the device's MAC. As such, the device will continue to pull the dynamic lease's specified IP until that lease expires. You have to manually delete the lease to make the device pull the correct IP (or, well, wait 24 hours). ### Steps to reproduce Steps to reproduce the behavior: 1. Have PiHole doing DHCP 2. Have a device use the PiHole DHCP to pull an IP 3. Add a static lease *for the device which already has a dynamic lease*. 4. Cause device to try to pull a new IP address. 5. Address from dynamic lease is given to device, rather then the static lease. ## Debug Token - URL: Not relevant, this is a logic issue.  ### Screenshots N/A ### Additional context Slightly off topic, but the sorting of IP addresses on the DHCP page is also incorrect. It currently sorts using pure alphanumeric ordering, which means you get - 192.168.1.2 - 192.168.1.20 - 192.168.1.200 - 192.168.1.3 At least the IP addresses should be sorted numerically, rather then alphanumerically.

We already have a way to manually delete the current lease since PR

github.com/pi-hole/AdminLTE

Add button to remove dynamic DHCP leases

pi-hole:devel ← pi-hole:new/unlink_DHCP_lease

opened 12:45PM - 23 Nov 20 UTC

DL6ER

+56 -0

**By submitting this pull request, I confirm the following:** - [X] I have r…ead and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md), as well as this entire template. - [X] I have made only one major change in my proposed changes. - [X] I have commented my proposed changes within the code. - [X] I have tested my proposed changes, and have included unit tests where possible. - [X] I am willing to help maintain this change if there are issues with it later. - [X] I give this submission freely and claim no ownership. - [X] It is compatible with the [EUPL 1.2 license](https://opensource.org/licenses/EUPL-1.1) - [X] I have squashed any insignificant commits. ([`git rebase`](http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html)) --- **What does this PR aim to accomplish?:** Add button to remove dynamic DHCP leases. They are immediately removed both from FTL and the `dhcp.leases` file. FTL takes care of updating the file!) WITHOUT the need for a restart of the DHCP/DNS resolver. See the new red trash icon on the dynamic leases table: ![Screenshot at 2020-11-23 13-40-23](https://user-images.githubusercontent.com/16748619/99963776-939dce80-2d92-11eb-81fd-2cbe94608402.png) Clicking on the one non-blurred entry deletes the lease currently active for `dominik-desktop`. The progress is reported by a status message on the top right corner: ![Screenshot at 2020-11-23 13-37-29](https://user-images.githubusercontent.com/16748619/99963784-97315580-2d92-11eb-836a-6200cdd3a858.png) **How does this PR accomplish the above?:** Adds a button to call the new `delete-release` API callback in FTL (see https://github.com/pi-hole/FTL/pull/932) **What documentation changes (if any) are needed to support this PR?:** None

system · January 27, 2023, 11:56am

This topic was automatically closed 180 days after the last reply. New replies are no longer allowed.