Add DNS.WATCH to the default DNS servers

Skittels · January 31, 2017, 11:55am

It would like to have DNS.WATCH added to the default list of DNS servers.

Why?

They support IPv6
They support DNSSEC
No logging

PromoFaux · February 18, 2017, 10:16am

Here's the relevant part you'd need to modify should you wish to do a pull request!

pi-hole/pi-hole/blob/master/automated install/basic-install.sh#L439-L522


    printf "  %b Installed %s\\n" "${TICK}" "${EPEL_PKG}"
fi

# The default php on CentOS 7.x is 5.4 which is EOL
# Check if the version of PHP available via installed repositories is >= to PHP 7
AVAILABLE_PHP_VERSION=$("${PKG_MANAGER}" info php | grep -i version | grep -o '[0-9]\+' | head -1)
if [[ $AVAILABLE_PHP_VERSION -ge $SUPPORTED_CENTOS_PHP_VERSION ]]; then
    # Since PHP 7 is available by default, install via default PHP package names
    : # do nothing as PHP is current
else
    REMI_PKG="remi-release"
    REMI_REPO="remi-php72"
    rpm -q ${REMI_PKG} &> /dev/null || rc=$?
if [[ $rc -ne 0 ]]; then
    # The PHP version available via default repositories is older than version 7
    if ! whiptail --defaultno --title "PHP 7 Update (recommended)" --yesno "PHP 7.x is recommended for both security and language features.\\nWould you like to install PHP7 via Remi's RPM repository?\\n\\nSee: https://rpms.remirepo.net for more information" "${r}" "${c}"; then
        # User decided to NOT update PHP from REMI, attempt to install the default available PHP version
        printf "  %b User opt-out of PHP 7 upgrade on CentOS. Deprecated PHP may be in use.\\n" "${INFO}"
        : # continue with unsupported php version
    else

This file has been truncated. show original

If not, let me know and I'll sumbit it on your behalf...

Skittels · February 18, 2017, 12:35pm

Thanks!

I made the pull request.

github.com/pi-hole/pi-hole

Adds DNS.WATCH to default dns servers

pi-hole:development ← nnt0:even_more_dns

opened 12:33PM - 18 Feb 17 UTC

nnt0

+6 -0

**By submitting this pull request, I confirm the following (please check boxes, …eg [X]) _Failure to fill the template will close your PR_:** ***Please submit all pull requests against the `development` branch. Failure to do so will delay or deny your request*** - [x] I have read and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md). - [x] I have checked that [another pull request](https://github.com/pi-hole/pi-hole/pulls) for this purpose does not exist. - [x] I have considered, and confirmed that this submission will be valuable to others. - [x] I accept that this submission may not be used, and the pull request closed at the will of the maintainer. - [x] I give this submission freely, and claim no ownership to its content. **How familiar are you with the codebase?:** 3 --- Adds DNS.WATCH as a selectable dns server. _This template was created based on the work of [`udemy-dl`](https://github.com/nishad/udemy-dl/blob/master/LICENSE)._

PromoFaux · February 18, 2017, 5:53pm

Thanks! I've also opened up a pull request to add them to the Admin page, too